hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: fix performance issue in ServerSideUrlRedirect.qll

Browse Source
This commit is contained in:
Asger F
2018-08-17 14:01:45 +01:00
parent 031964e853
commit 4dc1462b6b
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
javascript/ql/src/semmle/javascript/security/dataflow/ServerSideUrlRedirect.qll
View File

@@ -36,12 +36,9 @@ module ServerSideUrlRedirect {
}
/**
* Gets a "prefix predecessor" of `nd`, that is, either a normal data flow predecessor
* or the left operand of `nd` if it is a concatenation.
* Gets the left operand of `nd` if it is a concatenation.
*/
private DataFlow::Node prefixPred(DataFlow::Node nd) {
result = nd.getAPredecessor()
or
private DataFlow::Node getPrefixOperand(DataFlow::Node nd) {
exists (Expr e | e instanceof AddExpr or e instanceof AssignAddExpr |
nd = DataFlow::valueNode(e) and
result = DataFlow::valueNode(e.getChildExpr(0))
@@ -53,7 +50,8 @@ module ServerSideUrlRedirect {
*/
private DataFlow::Node prefixCandidate(Sink sink) {
result = sink or
result = prefixPred(prefixCandidate(sink))
result = getPrefixOperand(prefixCandidate(sink)) or
result = prefixCandidate(sink).getAPredecessor()
}
/**
@@ -62,7 +60,8 @@ module ServerSideUrlRedirect {
private Expr getAPrefix(Sink sink) {
exists (DataFlow::Node prefix |
prefix = prefixCandidate(sink) and
not exists(prefixPred(prefix)) and
not exists(getPrefixOperand(prefix)) and
not exists(prefix.getAPredecessor()) and
result = prefix.asExpr()
)
}