hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-24 16:17:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove IsMaDTaintStepCharacteristic for now because it's catching all our known sinks as well as taint steps

Browse Source
This commit is contained in:
tiferet
2023-02-15 14:39:26 -08:00
parent f73b3e0d97
commit 4db03cf4ae
1 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll
View File

@@ -497,22 +497,21 @@ private class IsSanitizerCharacteristic extends NotASinkCharacteristic {
}
}
/**
* An EndpointFilterCharacteristic that indicates that an endpoint is a MaD taint step. MaD modeled taint steps are
* global, so they are not sinks for any query. Non-MaD taint steps might be specific to a particular query, so we don't
* filter those out.
*/
private class IsMaDTaintStepCharacteristic extends NotASinkCharacteristic {
IsMaDTaintStepCharacteristic() { this = "mad taint step" }
override predicate appliesToEndpoint(DataFlow::Node n) {
FlowSummaryImpl::Private::Steps::summaryThroughStepValue(n, _, _) or
FlowSummaryImpl::Private::Steps::summaryThroughStepTaint(n, _, _) or
FlowSummaryImpl::Private::Steps::summaryGetterStep(n, _, _, _) or
FlowSummaryImpl::Private::Steps::summarySetterStep(n, _, _, _)
}
}
// /**
// * An EndpointFilterCharacteristic that indicates that an endpoint is a MaD taint step. MaD modeled taint steps are
// * global, so they are not sinks for any query. Non-MaD taint steps might be specific to a particular query, so we don't
// * filter those out.
// */
// private class IsMaDTaintStepCharacteristic extends NotASinkCharacteristic {
// IsMaDTaintStepCharacteristic() { this = "mad taint step" }
// override predicate appliesToEndpoint(DataFlow::Node n) {
// FlowSummaryImpl::Private::Steps::summaryThroughStepValue(n, _, _)
// or
// // FlowSummaryImpl::Private::Steps::summaryThroughStepTaint(n, _, _) or
// // FlowSummaryImpl::Private::Steps::summaryGetterStep(n, _, _, _) or
// FlowSummaryImpl::Private::Steps::summarySetterStep(n, _, _, _)
// }
// }
/**
* An EndpointFilterCharacteristic that indicates that an endpoint is an argument to a safe external API method.
*