From 4db03cf4ae1f0c7e4fbd57e836f3c19b3211f69a Mon Sep 17 00:00:00 2001 From: tiferet Date: Wed, 15 Feb 2023 14:39:26 -0800 Subject: [PATCH] Remove `IsMaDTaintStepCharacteristic` for now because it's catching all our known sinks as well as taint steps --- .../EndpointCharacteristics.qll | 31 +++++++++---------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll b/java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll index 379ccd61a15..5d4d0a9c8ba 100644 --- a/java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll +++ b/java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll @@ -497,22 +497,21 @@ private class IsSanitizerCharacteristic extends NotASinkCharacteristic { } } -/** - * An EndpointFilterCharacteristic that indicates that an endpoint is a MaD taint step. MaD modeled taint steps are - * global, so they are not sinks for any query. Non-MaD taint steps might be specific to a particular query, so we don't - * filter those out. - */ -private class IsMaDTaintStepCharacteristic extends NotASinkCharacteristic { - IsMaDTaintStepCharacteristic() { this = "mad taint step" } - - override predicate appliesToEndpoint(DataFlow::Node n) { - FlowSummaryImpl::Private::Steps::summaryThroughStepValue(n, _, _) or - FlowSummaryImpl::Private::Steps::summaryThroughStepTaint(n, _, _) or - FlowSummaryImpl::Private::Steps::summaryGetterStep(n, _, _, _) or - FlowSummaryImpl::Private::Steps::summarySetterStep(n, _, _, _) - } -} - +// /** +// * An EndpointFilterCharacteristic that indicates that an endpoint is a MaD taint step. MaD modeled taint steps are +// * global, so they are not sinks for any query. Non-MaD taint steps might be specific to a particular query, so we don't +// * filter those out. +// */ +// private class IsMaDTaintStepCharacteristic extends NotASinkCharacteristic { +// IsMaDTaintStepCharacteristic() { this = "mad taint step" } +// override predicate appliesToEndpoint(DataFlow::Node n) { +// FlowSummaryImpl::Private::Steps::summaryThroughStepValue(n, _, _) +// or +// // FlowSummaryImpl::Private::Steps::summaryThroughStepTaint(n, _, _) or +// // FlowSummaryImpl::Private::Steps::summaryGetterStep(n, _, _, _) or +// FlowSummaryImpl::Private::Steps::summarySetterStep(n, _, _, _) +// } +// } /** * An EndpointFilterCharacteristic that indicates that an endpoint is an argument to a safe external API method. *