JS: Restrict useSelector steps to local callbacks

2026-05-02 04:05:14 +02:00 · 2023-04-11 13:03:47 +02:00
parent 3cc931306f
commit 4ce03d4dc4
2 changed files with 1 additions and 11 deletions
--- a/javascript/ql/lib/semmle/javascript/frameworks/Redux.qll
+++ b/javascript/ql/lib/semmle/javascript/frameworks/Redux.qll
@@ -994,7 +994,7 @@ module Redux {
      override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
        exists(API::CallNode call |
          call = useSelector().getACall() and
-          pred = call.getParameter(0).getReturn().asSink() and
+          pred = call.getCallback(0).getReturnNode() and
          succ = call
        )
      }