hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Address review comment.

Browse Source
This commit is contained in:
Calum Grant
2020-04-07 19:58:48 +01:00
parent abf6be6030
commit 4c7d413fa4
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs
View File

@@ -114,7 +114,7 @@ namespace Semmle.Extraction.CSharp.Entities
{
if (symbol.IsStatic) trapFile.Write("static");
trapFile.WriteSubId(ContainingType);
AddParametersToId(Context, trapFile, symbol, symbol);
AddParametersToId(Context, trapFile, symbol);
trapFile.Write(";constructor");
}

8
csharp/extractor/Semmle.Extraction.CSharp/Entities/Method.cs
View File

@@ -134,7 +134,7 @@ namespace Semmle.Extraction.CSharp.Entities
}
}
AddParametersToId(m.Context, trapFile, m.symbol, m.symbol);
AddParametersToId(m.Context, trapFile, m.symbol);
switch (m.symbol.MethodKind)
{
case MethodKind.PropertyGet:
@@ -204,7 +204,7 @@ namespace Semmle.Extraction.CSharp.Entities
type.BuildTypeId(cx, trapFile, false, symbolBeingDefined, (cx0, tb0, type0, g) => AddSignatureTypeToId(cx, tb0, method, type0, g));
}
protected static void AddParametersToId(Context cx, TextWriter trapFile, IMethodSymbol method, ISymbol symbolBeingDefined)
protected static void AddParametersToId(Context cx, TextWriter trapFile, IMethodSymbol method)
{
trapFile.Write('(');
int index = 0;
@@ -212,13 +212,13 @@ namespace Semmle.Extraction.CSharp.Entities
if (method.MethodKind == MethodKind.ReducedExtension)
{
trapFile.WriteSeparator(",", ref index);
AddSignatureTypeToId(cx, trapFile, method, method.ReceiverType, symbolBeingDefined);
AddSignatureTypeToId(cx, trapFile, method, method.ReceiverType, method);
}
foreach (var param in method.Parameters)
{
trapFile.WriteSeparator(",", ref index);
AddSignatureTypeToId(cx, trapFile, method, param.Type, symbolBeingDefined);
AddSignatureTypeToId(cx, trapFile, method, param.Type, method);
switch (param.RefKind)
{
case RefKind.Out: