hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Addressed comments

Browse Source 
Co-authored-by: Asgerf <asgerf@github.com>
This commit is contained in:
Napalys
2025-04-09 12:16:53 +02:00
parent 873db7c121
commit 4bc3e9e736
2 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/lib/semmle/javascript/internal/flow_summaries/Decoders.qll
View File

@@ -17,8 +17,7 @@ class DecodeLike extends SummarizedCallable {
DecodeLike() { this = "TextDecoder#decode" }
override InstanceCall getACall() {
result =
textDecoderConstructorRef().getAnInstantiation().getReturn().getMember("decode").getACall()
result = textDecoderConstructorRef().getInstance().getMember("decode").getACall()
}
override predicate propagatesFlow(string input, string output, boolean preservesValue) {

22
javascript/ql/lib/semmle/javascript/internal/flow_summaries/TypedArrays.qll
View File

@@ -37,11 +37,11 @@ class BufferTypedArray extends DataFlow::AdditionalFlowStep {
}
}
class SetLike extends SummarizedCallable {
SetLike() { this = "TypedArray#set" }
class TypedArraySet extends SummarizedCallable {
TypedArraySet() { this = "TypedArray#set" }
override InstanceCall getACall() {
result = typedArrayConstructorRef().getAnInstantiation().getReturn().getMember("set").getACall()
result = typedArrayConstructorRef().getInstance().getMember("set").getACall()
}
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
@@ -51,13 +51,10 @@ class SetLike extends SummarizedCallable {
}
}
class SubArrayLike extends SummarizedCallable {
SubArrayLike() { this = "TypedArray#subarray" }
class TypedArraySubarray extends SummarizedCallable {
TypedArraySubarray() { this = "TypedArray#subarray" }
override InstanceCall getACall() {
result =
typedArrayConstructorRef().getAnInstantiation().getReturn().getMember("subarray").getACall()
}
override InstanceCall getACall() { result.getMethodName() = "subarray" }
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
preservesValue = true and
@@ -95,12 +92,7 @@ class TransferLike extends SummarizedCallable {
TransferLike() { this = "ArrayBuffer#transfer" }
override InstanceCall getACall() {
result =
arrayBufferConstructorRef()
.getAnInstantiation()
.getReturn()
.getMember(["transfer", "transferToFixedLength"])
.getACall()
result.getMethodName() = ["transfer", "transferToFixedLength"]
}
override predicate propagatesFlow(string input, string output, boolean preservesValue) {