Apply suggestions from code review

Co-authored-by: Cornelius Riemenschneider <cornelius@github.com>
This commit is contained in:
Paolo Tranquilli
2024-04-09 14:44:44 +02:00
committed by GitHub
parent 11729aaf6e
commit 4b205ff96d

View File

@@ -6,7 +6,6 @@ bazel build //java/kotlin-extractor:codeql-extractor-kotlin-<variant>-<version>
```
where `<variant>` is either `standalone` or `embeddable`, and `<version>` is one of the supported versions.
For the moment both variants where tested by replacing them into `target/intree/codeql-java` and running one relevant integration test.
```
bazel build //java/kotlin-extractor
@@ -23,7 +22,7 @@ If `kotlinc` is updated, bazel won't be aware of it and will therefore keep the
* `CODEQL_KOTLIN_SINGLE_VERSION= bazel build //java/kotlin-extractor`
"""
# notice that this file is used in the `@codeql_koblin_embeddable` external repo, which means we need to
# This file is used in the `@codeql_kotlin_embeddable` external repo, which means we need to
# reference explicitly @codeql
load(
"@codeql//java/kotlin-extractor:versions.bzl",
@@ -143,7 +142,7 @@ _resources = [
]
# default aliases, based on the kotlinc version installed on the host
# * default version can be overridden with env variableCODEQL_KOTLIN_SINGLE_VERSION
# * default version can be overridden with env variable CODEQL_KOTLIN_SINGLE_VERSION
# * setting CODEQL_KOTLIN_SINGLE_VERSION_EMBEDDABLE=true overrides the default variant
# * when a new kotlinc version is installed, you'll need to either `bazel clean` or
# `bazel fetch --force @codeql_kotlin_defaults//:all` to refresh the default