diff --git a/python/ql/src/Imports/ImportandImportFrom.ql b/python/ql/src/Imports/ImportandImportFrom.ql index f77ce345113..48ada91b11b 100644 --- a/python/ql/src/Imports/ImportandImportFrom.ql +++ b/python/ql/src/Imports/ImportandImportFrom.ql @@ -2,7 +2,9 @@ * @name Module is imported with 'import' and 'import from' * @description A module is imported with the "import" and "import from" statements * @kind problem - * @tags maintainability + * @tags quality + * maintainability + * readability * @problem.severity recommendation * @sub-severity low * @precision very-high diff --git a/python/ql/src/Imports/ModuleImportsItself.ql b/python/ql/src/Imports/ModuleImportsItself.ql index c876853fff5..72d223da3db 100644 --- a/python/ql/src/Imports/ModuleImportsItself.ql +++ b/python/ql/src/Imports/ModuleImportsItself.ql @@ -2,7 +2,8 @@ * @name Module imports itself * @description A module imports itself * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * @problem.severity recommendation * @sub-severity high diff --git a/python/ql/src/Imports/MultipleImports.ql b/python/ql/src/Imports/MultipleImports.ql index fdff082e0c5..f23ae25e674 100644 --- a/python/ql/src/Imports/MultipleImports.ql +++ b/python/ql/src/Imports/MultipleImports.ql @@ -2,7 +2,8 @@ * @name Module is imported more than once * @description Importing a module a second time has no effect and impairs readability * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * @problem.severity recommendation * @sub-severity high diff --git a/python/ql/src/Imports/UnintentionalImport.ql b/python/ql/src/Imports/UnintentionalImport.ql index cdbcec278dd..1faf3bb55f3 100644 --- a/python/ql/src/Imports/UnintentionalImport.ql +++ b/python/ql/src/Imports/UnintentionalImport.ql @@ -3,8 +3,9 @@ * @description Importing a module using 'import *' may unintentionally pollute the global * namespace if the module does not define `__all__` * @kind problem - * @tags maintainability - * modularity + * @tags quality + * maintainability + * readability * @problem.severity recommendation * @sub-severity high * @precision very-high diff --git a/python/ql/src/Imports/UnusedImport.ql b/python/ql/src/Imports/UnusedImport.ql index a4990a3a34c..02035690165 100644 --- a/python/ql/src/Imports/UnusedImport.ql +++ b/python/ql/src/Imports/UnusedImport.ql @@ -2,7 +2,8 @@ * @name Unused import * @description Import is not required as it is not used * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * @problem.severity recommendation * @sub-severity high diff --git a/python/ql/src/Statements/AssertOnTuple.ql b/python/ql/src/Statements/AssertOnTuple.ql index e86e05483c3..1dbdc5a0e17 100644 --- a/python/ql/src/Statements/AssertOnTuple.ql +++ b/python/ql/src/Statements/AssertOnTuple.ql @@ -2,8 +2,9 @@ * @name Asserting a tuple * @description Using an assert statement to test a tuple provides no validity checking. * @kind problem - * @tags reliability - * maintainability + * @tags quality + * reliability + * correctness * external/cwe/cwe-670 * @problem.severity error * @sub-severity low diff --git a/python/ql/src/Statements/ConstantInConditional.ql b/python/ql/src/Statements/ConstantInConditional.ql index 0b12d6efd98..9aa180c1937 100644 --- a/python/ql/src/Statements/ConstantInConditional.ql +++ b/python/ql/src/Statements/ConstantInConditional.ql @@ -2,7 +2,8 @@ * @name Constant in conditional expression or statement * @description The conditional is always true or always false * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * external/cwe/cwe-561 * external/cwe/cwe-570 diff --git a/python/ql/src/Statements/NestedLoopsSameVariable.ql b/python/ql/src/Statements/NestedLoopsSameVariable.ql index f57fa9b361a..48d9c7beb78 100644 --- a/python/ql/src/Statements/NestedLoopsSameVariable.ql +++ b/python/ql/src/Statements/NestedLoopsSameVariable.ql @@ -3,8 +3,9 @@ * @description Nested loops in which the target variable is the same for each loop make * the behavior of the loops difficult to understand. * @kind problem - * @tags maintainability - * correctness + * @tags quality + * maintainability + * readability * @problem.severity recommendation * @sub-severity high * @precision very-high diff --git a/python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql b/python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql index de293a7aeea..c4deb4e6427 100644 --- a/python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql +++ b/python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql @@ -3,7 +3,8 @@ * @description Redefining a variable in an inner loop and then using * the variable in an outer loop causes unexpected behavior. * @kind problem - * @tags maintainability + * @tags quality + * reliability * correctness * @problem.severity error * @sub-severity low diff --git a/python/ql/src/Statements/RedundantAssignment.ql b/python/ql/src/Statements/RedundantAssignment.ql index 097e4d0052f..40acebf22a0 100644 --- a/python/ql/src/Statements/RedundantAssignment.ql +++ b/python/ql/src/Statements/RedundantAssignment.ql @@ -2,7 +2,8 @@ * @name Redundant assignment * @description Assigning a variable to itself is useless and very likely indicates an error in the code. * @kind problem - * @tags reliability + * @tags quality + * maintainability * useless-code * external/cwe/cwe-563 * @problem.severity error diff --git a/python/ql/src/Statements/UnnecessaryElseClause.ql b/python/ql/src/Statements/UnnecessaryElseClause.ql index 35ac254b276..5e4763637a9 100644 --- a/python/ql/src/Statements/UnnecessaryElseClause.ql +++ b/python/ql/src/Statements/UnnecessaryElseClause.ql @@ -2,7 +2,8 @@ * @name Unnecessary 'else' clause in loop * @description An 'else' clause in a 'for' or 'while' statement that does not contain a 'break' is redundant. * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * @problem.severity warning * @sub-severity low diff --git a/python/ql/src/Statements/UnnecessaryPass.ql b/python/ql/src/Statements/UnnecessaryPass.ql index 215fac5192e..1a842639b76 100644 --- a/python/ql/src/Statements/UnnecessaryPass.ql +++ b/python/ql/src/Statements/UnnecessaryPass.ql @@ -2,7 +2,8 @@ * @name Unnecessary pass * @description Unnecessary 'pass' statement * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * @problem.severity warning * @sub-severity low diff --git a/python/ql/src/Variables/GlobalAtModuleLevel.ql b/python/ql/src/Variables/GlobalAtModuleLevel.ql index e0ac59d2e72..e68caf2adf4 100644 --- a/python/ql/src/Variables/GlobalAtModuleLevel.ql +++ b/python/ql/src/Variables/GlobalAtModuleLevel.ql @@ -2,7 +2,8 @@ * @name Use of 'global' at module level * @description Use of the 'global' statement at module level * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * @problem.severity warning * @sub-severity low diff --git a/python/ql/src/Variables/MultiplyDefined.ql b/python/ql/src/Variables/MultiplyDefined.ql index 7d0e76fb6c3..3c26ff0b1eb 100644 --- a/python/ql/src/Variables/MultiplyDefined.ql +++ b/python/ql/src/Variables/MultiplyDefined.ql @@ -2,7 +2,8 @@ * @name Variable defined multiple times * @description Assignment to a variable occurs multiple times without any intermediate use of that variable * @kind problem - * @tags maintainability + * @tags quality + * maintainability * useless-code * external/cwe/cwe-563 * @problem.severity warning