hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Simple fix.

Browse Source
This commit is contained in:
Geoffrey White
2024-07-31 14:46:25 +01:00
parent c04428dedc
commit 4aea4c0323
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/Critical/MemoryMayNotBeFreed.ql
View File

@@ -39,7 +39,7 @@ predicate allocCallOrIndirect(Expr e) {
allocCallOrIndirect(rtn.getExpr())
or
// return variable assigned with alloc
exists(Variable v |
exists(StackVariable v |
v = rtn.getExpr().(VariableAccess).getTarget() and
allocCallOrIndirect(v.getAnAssignedValue()) and
not assignedToFieldOrGlobal(v, _)

2
cpp/ql/test/query-tests/Critical/MemoryFreed/MemoryMayNotBeFreed.expected
View File

@@ -1,4 +1,2 @@
| test_free.cpp:36:22:36:35 | ... = ... | This memory allocation may not be released at $@. | test_free.cpp:38:1:38:1 | return ... | this exit point |
| test_free.cpp:267:12:267:17 | call to malloc | This memory allocation may not be released at $@. | test_free.cpp:270:1:270:1 | return ... | this exit point |
| test_free.cpp:420:23:420:31 | call to getBuffer | This memory allocation may not be released at $@. | test_free.cpp:428:1:428:1 | return ... | this exit point |
| test_free.cpp:427:25:427:33 | call to getBuffer | This memory allocation may not be released at $@. | test_free.cpp:428:1:428:1 | return ... | this exit point |

4
cpp/ql/test/query-tests/Critical/MemoryFreed/test_free.cpp
View File

@@ -417,12 +417,12 @@ public:
void testHasGetter() {
HasGetterAndFree hg;
void *buffer = hg.getBuffer(); // GOOD (freed in destructor) [FALSE POSITIVE]
void *buffer = hg.getBuffer(); // GOOD (freed in destructor)
HasGetterNoFree hg2;
void *buffer2 = hg2.getBuffer(); // GOOD (freed below)
free(buffer2);
HasGetterNoFree hg3;
void *buffer3 = hg3.getBuffer(); // BAD (not freed)
void *buffer3 = hg3.getBuffer(); // BAD (not freed) [NOT DETECTED]
}