hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Remove 'TODO' now that the implementation has been fixed.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-07-24 12:24:46 +02:00
parent 4345369e9b
commit 4a276c37ac
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/lib/semmle/code/cpp/security/InvalidPointerDereference/InvalidPointerToDereference.qll
View File

@@ -20,11 +20,9 @@
* here). So this step is about identifying which of those out-of-bounds pointers identified from step 1 that are
* actually being dereferenced. We do this using a regular dataflow configuration (see `InvalidPointerToDerefConfig`).
*
* This dataflow traversal defines the set of sources as any dataflow node that is non-strictly upper-bounded by the
* pointer-arithmetic instruction identified by `AllocationToInvalidPointer.qll`. (TODO: I'm pretty sure this is incorrect,
* and we should define the set of sources as anything that is non-strictly _lower_ bounded by the pointer-arithmetic
* instruction). That is, the set of sources is any dataflow node `source` such that `source.asInstruction <= pai + delta1`
* for some `delta1 >= 0`.
* This dataflow traversal defines the set of sources as any dataflow node that is non-strictly lower-bounded by the
* pointer-arithmetic instruction identified by `AllocationToInvalidPointer.qll`. That is, the set of sources is any
* dataflow node `source` such that `source.asInstruction() >= pai + delta1` for some `delta1 >= 0`.
*
* The set of sinks is defined to be any address operand `addr` that is non-strictly upper-bounded by the sink. That is,
* any dataflow node `n` such that `addr <= sink.asInstruction() + delta2` for some `delta2`. We call the instruction that