hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed code style for SockJS

Browse Source 
also fixed appCreation, thanks to Erik Krogh.
This commit is contained in:
kyprizel
2020-03-23 17:16:17 +03:00
committed by GitHub
parent ee0b65ad39
commit 49e5a22cab
1 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
javascript/ql/src/experimental/SockJS/SockJS.qll
View File

@@ -1,4 +1,4 @@
/**
/**
* Provides classes for working with [SockJS](http://sockjs.org).
*/
@@ -9,25 +9,26 @@ import DataFlow::PathGraph
* A model of the `SockJS` websocket data handler (https://sockjs.org).
*/
module SockJS {
class SourceFromSocketJS extends RemoteFlowSource {
class SourceFromSocketJS extends RemoteFlowSource {
/**
* Access to user-controlled data object received from websocket
* Access to user-controlled data object received from websocket
* For example:
* ```
* server.on('connection', function(conn) {
* conn.on('data', function(message) {
* ...
* });
* });
* });
* ```
*/
*/
SourceFromSocketJS() {
exists(DataFlow::CallNode createServer,
DataFlow::CallNode connNode,
DataFlow::CallNode dataHandlerNode |
createServer = appCreation() and
exists(
DataFlow::CallNode createServer, DataFlow::CallNode connNode,
DataFlow::CallNode dataHandlerNode
|
createServer = appCreation() and
connNode = createServer.getAMethodCall("on") and
connNode.getArgument(0).getStringValue() = "connection" and
connNode.getArgument(0).getStringValue() = "connection" and
dataHandlerNode = connNode.getCallback(1).getParameter(0).getAMethodCall("on") and
dataHandlerNode.getArgument(0).getStringValue() = "data" and
this = dataHandlerNode.getCallback(1).getParameter(0)
@@ -42,7 +43,5 @@ module SockJS {
*/
private DataFlow::CallNode appCreation() {
result = DataFlow::moduleImport("sockjs").getAMemberCall("createServer")
or
result = DataFlow::moduleMember("sockjs", "createServer")
}
}