From 49b8b0bca3e21e849cc46ad78ddc82650e36ee68 Mon Sep 17 00:00:00 2001 From: Owen Mansel-Chan Date: Fri, 5 Sep 2025 14:20:06 +0100 Subject: [PATCH] Remove local flow step from SSA defn to SSA capture --- .../semmle/go/dataflow/internal/DataFlowPrivate.qll | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll b/go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll index 3b8ed07c1a3..f05859de813 100644 --- a/go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll +++ b/go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll @@ -72,16 +72,6 @@ predicate basicLocalFlowStep(Node nodeFrom, Node nodeTo) { nodeTo = ssaNode(succ.getVariable()) ) or - // SSA defn -> SSA capture - exists(SsaExplicitDefinition pred, SsaVariableCapture succ | - // Check: should these flow from PHIs as well? Perhaps they should be included - // in the use-use graph? - succ.getSourceVariable() = pred.getSourceVariable() - | - nodeFrom = ssaNode(pred.getVariable()) and - nodeTo = ssaNode(succ.getVariable()) - ) - or // SSA defn -> first SSA use exists(SsaDefinition pred, IR::Instruction succ | succ = pred.getAFirstUse() | (pred instanceof SsaExplicitDefinition or pred instanceof SsaVariableCapture) and