hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 13:45:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Replace ValidatedVariable with guarded accesses.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2019-05-14 11:26:52 +02:00
parent 5466ae619d
commit 48b19f1fea
7 changed files with 57 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/test/query-tests/security/CWE-089/semmle/examples/ValidatedVariable.expected
View File

@@ -1 +1 @@
| Test.java:60:4:60:29 | Test:60 | Test.java:60:4:60:29 | String category |
| Test.java:64:8:64:15 | category |

4
java/ql/test/query-tests/security/CWE-089/semmle/examples/ValidatedVariable.ql
View File

@@ -1,4 +1,4 @@
import semmle.code.java.security.Validation
from ValidatedVariable var
select var.getLocation(), var
from ValidatedVariableAccess va
select va

5
java/ql/test/query-tests/security/CWE-089/semmle/examples/controlledString.expected
View File

@@ -5,20 +5,16 @@
| checkIdentifier | 1 | Validation.java:7:16:7:16 | 0 |
| checkIdentifier | 1 | Validation.java:7:19:7:19 | i |
| checkIdentifier | 1 | Validation.java:7:19:7:33 | ... < ... |
| checkIdentifier | 1 | Validation.java:7:23:7:24 | id |
| checkIdentifier | 1 | Validation.java:7:23:7:33 | length(...) |
| checkIdentifier | 1 | Validation.java:7:36:7:36 | i |
| checkIdentifier | 1 | Validation.java:7:36:7:38 | ...++ |
| checkIdentifier | 2 | Validation.java:8:9:8:24 | c |
| checkIdentifier | 2 | Validation.java:8:13:8:14 | id |
| checkIdentifier | 2 | Validation.java:8:13:8:24 | charAt(...) |
| checkIdentifier | 2 | Validation.java:8:23:8:23 | i |
| checkIdentifier | 3 | Validation.java:9:8:9:29 | !... |
| checkIdentifier | 3 | Validation.java:9:9:9:29 | isLetter(...) |
| checkIdentifier | 3 | Validation.java:9:28:9:28 | c |
| checkIdentifier | 4 | Validation.java:10:32:10:53 | "Invalid identifier: " |
| checkIdentifier | 4 | Validation.java:10:32:10:58 | ... + ... |
| checkIdentifier | 4 | Validation.java:10:57:10:58 | id |
| controlledStrings | 4 | Test.java:114:26:114:79 | "SELECT ITEM,PRICE FROM PRODUCT WHERE ITEM_CATEGORY='" |
| controlledStrings | 4 | Test.java:114:26:115:17 | ... + ... |
| controlledStrings | 4 | Test.java:114:26:115:38 | ... + ... |
@@ -78,7 +74,6 @@
| tainted | 22 | Test.java:51:19:51:72 | "SELECT ITEM,PRICE FROM PRODUCT WHERE ITEM_CATEGORY='" |
| tainted | 24 | Test.java:53:19:53:36 | "' ORDER BY PRICE" |
| tainted | 31 | Test.java:60:27:60:27 | 1 |
| tainted | 32 | Test.java:61:31:61:38 | category |
| tainted | 34 | Test.java:63:20:63:73 | "SELECT ITEM,PRICE FROM PRODUCT WHERE ITEM_CATEGORY='" |
| tainted | 34 | Test.java:63:20:64:15 | ... + ... |
| tainted | 34 | Test.java:63:20:64:36 | ... + ... |

5
java/ql/test/query-tests/security/CWE-089/semmle/examples/taintedString.expected
View File

@@ -18,6 +18,7 @@
| Test.java:29:22:29:28 | tainted | 27 | Test.java:56:47:56:61 | querySbToString |
| Test.java:29:22:29:28 | tainted | 31 | Test.java:60:22:60:25 | args |
| Test.java:29:22:29:28 | tainted | 31 | Test.java:60:22:60:28 | ...[...] |
| Test.java:29:22:29:28 | tainted | 32 | Test.java:61:31:61:38 | category |
| Test.java:99:22:99:25 | good | 3 | Test.java:102:22:102:25 | args |
| Test.java:99:22:99:25 | good | 3 | Test.java:102:22:102:28 | ...[...] |
| Test.java:99:22:99:25 | good | 6 | Test.java:105:27:105:34 | category |
@@ -30,3 +31,7 @@
| Test.java:190:21:190:24 | main | 1 | Test.java:191:11:191:14 | args |
| Test.java:190:21:190:24 | main | 3 | Test.java:193:8:193:11 | args |
| Test.java:190:21:190:24 | main | 5 | Test.java:195:14:195:17 | args |
| Validation.java:6:21:6:35 | checkIdentifier | 1 | Validation.java:7:23:7:24 | id |
| Validation.java:6:21:6:35 | checkIdentifier | 2 | Validation.java:8:13:8:14 | id |
| Validation.java:6:21:6:35 | checkIdentifier | 4 | Validation.java:10:32:10:58 | ... + ... |
| Validation.java:6:21:6:35 | checkIdentifier | 4 | Validation.java:10:57:10:58 | id |