hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Respond to review comments.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2025-11-25 12:06:58 +00:00
parent eb6b08591d
commit 47ab307410
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
View File

@@ -2086,12 +2086,13 @@ predicate localExprFlow(Expr e1, Expr e2) {
* *
* This is possible in _almost_ all cases, but there are cases where it is * This is possible in _almost_ all cases, but there are cases where it is
* not possible to map between a field in the uninstantiated template to a * not possible to map between a field in the uninstantiated template to a
* field in the instantiated template. This problem appears to be only in the * field in the instantiated template. This happens in the case of local class
* case of a local class definition. So this abstract class has two * definitions (because the local class is not the template that constructs
* implementations: a non-local case (where we can represent a canonical field * the instantiation - it is the enclosing function). So this abstract class
* as the field declaration from an uninstantiated class template or a non- * has two implementations: a non-local case (where we can represent a
* templated class), and a local case (where we simply use the field from the * canonical field as the field declaration from an uninstantiated class
* instantiated class). * template or a non-templated class), and a local case (where we simply use
* the field from the instantiated class).
*/ */
abstract private class CanonicalField extends Field { abstract private class CanonicalField extends Field {
/** Gets a field represented by this canonical field. */ /** Gets a field represented by this canonical field. */