hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

minor updates, removed comments

Browse Source
This commit is contained in:
Jami Cogswell
2022-07-30 17:47:45 -04:00
parent e2374f816a
commit 475d67a4df
3 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/src/Security/CWE/CWE-489/DebuggableAttributeTrue.ql
View File

@@ -17,9 +17,5 @@ from AndroidXmlAttribute androidXmlAttr
where
androidXmlAttr.getName() = "debuggable" and
androidXmlAttr.getValue() = "true" and
not androidXmlAttr.getLocation().getFile().getAbsolutePath().matches("%/build%") // USE THIS (from speaking with Tony) - 11 MRVA results
//not androidXmlAttr.getLocation().toString().matches("%build%") // my original query - 2 MRVA results
//not androidXmlAttr.getLocation().toString().matches("%/build%") // 11 MRVA results
//not androidXmlAttr.getLocation().getFile().getAbsolutePath().matches("%build%") // 2 MRVA results...
// comment for test commit to new branch
select androidXmlAttr, "The 'debuggable' attribute is enabled."
not androidXmlAttr.getLocation().getFile().getRelativePath().matches("%/build%")
select androidXmlAttr, "The 'android:debuggable' attribute is enabled."

2
java/ql/src/Security/CWE/CWE-489/DebuggableFalse.xml
View File

@@ -1,5 +1,5 @@
<manifest ... >
<!-- GOOD: 'android:debuggable' set to false -->
<!-- GOOD: 'android:debuggable' set to 'false' -->
<application
android:debuggable="false">
<activity ... >

2
java/ql/src/Security/CWE/CWE-489/DebuggableTrue.xml
View File

@@ -1,5 +1,5 @@
<manifest ... >
<!-- BAD: 'android:debuggable' set to true -->
<!-- BAD: 'android:debuggable' set to 'true' -->
<application
android:debuggable="true">
<activity ... >