hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 05:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Minor edits

Browse Source
This commit is contained in:
Calum Grant
2020-05-06 14:48:20 +01:00
committed by Tom Hvitved
parent f4b1594461
commit 4740b47f5d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
csharp/ql/src/semmle/code/csharp/Type.qll
View File

@@ -1018,8 +1018,7 @@ class TypeMention extends @type_mention {
/**
* Module for reasoning about typerefs.
*/
// private
module TypeRefs {
private module TypeRefs {
/**
* A typeref is a reference to a type in some assembly.
* Often, a type can be present in multiple assemblies.
@@ -1044,14 +1043,14 @@ module TypeRefs {
}
/** Gets the location of a type. */
Location typeLocation(Type t) {
private Location typeLocation(Type t) {
type_location(t, result)
or
exists(Type decl | constructed_generic(decl, t) and result = typeLocation(decl))
}
/** Gets a "canonical location" for a type. A type has only one canonical location. */
Location canonicalTypeLocation(Type t) {
private Location canonicalTypeLocation(Type t) {
result = typeLocation(t) and
not locationIsBetter(result, typeLocation(t))
}
@@ -1062,10 +1061,11 @@ module TypeRefs {
or
typeLocation instanceof Assembly and betterLocation instanceof SourceLocation
or
typeLocation.(SourceLocation).getFile().getAbsolutePath() < betterLocation.(SourceLocation).getFile().getAbsolutePath()
typeLocation.(SourceLocation).getFile().getAbsolutePath() <
betterLocation.(SourceLocation).getFile().getAbsolutePath()
}
predicate isCanonicalType(Type type) {
private predicate isCanonicalType(Type type) {
not exists(TypeRef tr |
type = tr.getAType() and
locationIsBetter(canonicalTypeLocation(type), canonicalTypeLocation(tr.getAType()))