diff --git a/python/ql/test/experimental/dataflow/coverage/test.py b/python/ql/test/experimental/dataflow/coverage/test.py index 65f915cfd9b..f35339e4dca 100644 --- a/python/ql/test/experimental/dataflow/coverage/test.py +++ b/python/ql/test/experimental/dataflow/coverage/test.py @@ -726,15 +726,15 @@ def test_deep_callgraph(): return f5(arg) x = f6(SOURCE) - SINK(x) #$ MISSING:flow="SOURCE, l:-1 -> x" + SINK(x) #$ flow="SOURCE, l:-1 -> x" x = f5(SOURCE) - SINK(x) #$ MISSING:flow="SOURCE, l:-1 -> x" + SINK(x) #$ flow="SOURCE, l:-1 -> x" x = f4(SOURCE) - SINK(x) #$ MISSING:flow="SOURCE, l:-1 -> x" + SINK(x) #$ flow="SOURCE, l:-1 -> x" x = f3(SOURCE) - SINK(x) #$ MISSING:flow="SOURCE, l:-1 -> x" + SINK(x) #$ flow="SOURCE, l:-1 -> x" x = f2(SOURCE) - SINK(x) #$ MISSING:flow="SOURCE, l:-1 -> x" + SINK(x) #$ flow="SOURCE, l:-1 -> x" x = f1(SOURCE) SINK(x) #$ flow="SOURCE, l:-1 -> x" diff --git a/python/ql/test/experimental/dataflow/typetracking/moduleattr.expected b/python/ql/test/experimental/dataflow/typetracking/moduleattr.expected index 9720d759aa0..14f26b7803c 100644 --- a/python/ql/test/experimental/dataflow/typetracking/moduleattr.expected +++ b/python/ql/test/experimental/dataflow/typetracking/moduleattr.expected @@ -6,5 +6,6 @@ module_attr_tracker | import_as_attr.py:1:28:1:35 | GSSA Variable attr_ref | | import_as_attr.py:3:1:3:1 | GSSA Variable x | | import_as_attr.py:3:5:3:12 | ControlFlowNode for attr_ref | +| import_as_attr.py:5:1:5:10 | GSSA Variable attr_ref | | import_as_attr.py:6:5:6:5 | SSA variable y | | import_as_attr.py:6:9:6:16 | ControlFlowNode for attr_ref | diff --git a/python/ql/test/experimental/dataflow/typetracking/test.py b/python/ql/test/experimental/dataflow/typetracking/test.py index 8de0a3ded92..f0e93d79af2 100644 --- a/python/ql/test/experimental/dataflow/typetracking/test.py +++ b/python/ql/test/experimental/dataflow/typetracking/test.py @@ -60,10 +60,10 @@ def test_import(): def to_inner_scope(): x = tracked # $tracked def foo(): - y = x # $ MISSING: tracked - return y # $ MISSING: tracked - also_x = foo() # $ MISSING: tracked - print(also_x) # $ MISSING: tracked + y = x # $ tracked + return y # $ tracked + also_x = foo() # $ tracked + print(also_x) # $ tracked # ------------------------------------------------------------------------------ # Function decorator diff --git a/python/ql/test/experimental/dataflow/typetracking/tracked.ql b/python/ql/test/experimental/dataflow/typetracking/tracked.ql index c35775d0046..c0ed62e258f 100644 --- a/python/ql/test/experimental/dataflow/typetracking/tracked.ql +++ b/python/ql/test/experimental/dataflow/typetracking/tracked.ql @@ -24,6 +24,11 @@ class TrackedTest extends InlineExpectationsTest { tracked(t).flowsTo(e) and // Module variables have no sensible location, and hence can't be annotated. not e instanceof DataFlow::ModuleVariableNode and + // Global variables on line 0 also cannot be annotated + not e.getLocation().getStartLine() = 0 and + // We do not wish to annotate scope entry definitions, + // as they do not appear in the source code. + not e.asVar() instanceof ScopeEntryDefinition and tag = "tracked" and location = e.getLocation() and value = t.getAttr() and