From 46b13878469d806c9d9d23030ad870123b08ef75 Mon Sep 17 00:00:00 2001
From: Asger F <asgerf@github.com>
Date: Mon, 3 Nov 2025 10:05:39 +0100
Subject: [PATCH] JS: Make isAssignedInUniqueFile global, as it should be

---
 javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll b/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll
index 804542b0dc5..53e5a779a9b 100644
--- a/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll
+++ b/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll
@@ -206,6 +206,7 @@ module AccessPath {
    * Holds if the global `accessPath` is only assigned to from one file, not counting
    * self-assignments.
    */
+  overlay[global]
   predicate isAssignedInUniqueFile(string accessPath) {
     strictcount(File f | isAssignedInFile(accessPath, f)) = 1
   }
@@ -511,7 +512,7 @@ module AccessPath {
   /**
    * Holds if there is a step from `pred` to `succ` through an assignment to an access path.
    */
-  overlay[caller]
+  overlay[caller?]
   pragma[inline]
   predicate step(DataFlow::Node pred, DataFlow::Node succ) {
     exists(string name, Root root |