hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 17:23:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
This commit is contained in:
yoff
2022-02-01 10:06:37 +01:00
committed by GitHub
parent 68d18ead34
commit 45f0bfd8f0
2 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
python/ql/lib/semmle/python/frameworks/Ldap.qll
View File

@@ -15,22 +15,17 @@ private import semmle.python.ApiGraphs
*/
private module Ldap {
/**
* The name of an `ldap` method used to execute a query.
* The execution of an `ldap` query.
*
* See https://www.python-ldap.org/en/python-ldap-3.3.0/reference/ldap.html#functions
*/
private string ldapQueryMethodName() {
result in ["search", "search_s", "search_st", "search_ext", "search_ext_s"]
}
/** The execution of an `ldap` query. */
private class LdapQueryExecution extends DataFlow::CallCfgNode, LdapExecution::Range {
LdapQueryExecution() {
this =
API::moduleImport("ldap")
.getMember("initialize")
.getReturn()
.getMember(ldapQueryMethodName())
.getMember(["search", "search_s", "search_st", "search_ext", "search_ext_s"])
.getACall()
}
@@ -42,7 +37,7 @@ private module Ldap {
}
/**
* A class to find calls to `ldap.dn.escape_dn_chars`.
* A call to `ldap.dn.escape_dn_chars`.
*
* See https://github.com/python-ldap/python-ldap/blob/7ce471e238cdd9a4dd8d17baccd1c9e05e6f894a/Lib/ldap/dn.py#L17
*/
@@ -59,7 +54,7 @@ private module Ldap {
}
/**
* A class to find calls to `ldap.filter.escape_filter_chars`.
* A call to `ldap.filter.escape_filter_chars`.
*
* See https://www.python-ldap.org/en/python-ldap-3.3.0/reference/ldap-filter.html#ldap.filter.escape_filter_chars
*/

4
python/ql/lib/semmle/python/frameworks/Ldap3.qll
View File

@@ -35,7 +35,7 @@ private module Ldap3 {
}
/**
* A class to find calls to `ldap3.utils.dn.escape_rdn`.
* A call to `ldap3.utils.dn.escape_rdn`.
*
* See https://github.com/cannatag/ldap3/blob/4d33166f0869b929f59c6e6825a1b9505eb99967/ldap3/utils/dn.py#L390
*/
@@ -57,7 +57,7 @@ private module Ldap3 {
}
/**
* A class to find calls to `ldap3.utils.conv.escape_filter_chars`.
* A call to `ldap3.utils.conv.escape_filter_chars`.
*
* See https://github.com/cannatag/ldap3/blob/4d33166f0869b929f59c6e6825a1b9505eb99967/ldap3/utils/conv.py#L91
*/