From 45b5efad25a4138ac18a34d533d17ffa3d637871 Mon Sep 17 00:00:00 2001
From: Joe Farebrother <joefarebrother@github.com>
Date: Tue, 1 Jul 2025 16:39:12 +0100
Subject: [PATCH] Fix FPs and typo

---
 python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll        | 2 +-
 .../Classes/CallsToInitDel/SuperclassDelCalledMultipleTimes.ql  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll b/python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll
index 253360bf227..5fd28ef9ddf 100644
--- a/python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll
+++ b/python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll
@@ -8,7 +8,7 @@ predicate multipleCallsToSuperclassMethod(Function meth, Function calledMulti, s
   exists(DataFlow::MethodCallNode call1, DataFlow::MethodCallNode call2, Class cls |
     meth.getName() = name and
     meth.getScope() = cls and
-    not call1 = call2 and
+    call1.asExpr() != call2.asExpr() and
     calledMulti = getASuperCallTarget(cls, meth, call1) and
     calledMulti = getASuperCallTarget(cls, meth, call2) and
     nonTrivial(calledMulti)
diff --git a/python/ql/src/Classes/CallsToInitDel/SuperclassDelCalledMultipleTimes.ql b/python/ql/src/Classes/CallsToInitDel/SuperclassDelCalledMultipleTimes.ql
index d75d948809d..7aca3dee189 100644
--- a/python/ql/src/Classes/CallsToInitDel/SuperclassDelCalledMultipleTimes.ql
+++ b/python/ql/src/Classes/CallsToInitDel/SuperclassDelCalledMultipleTimes.ql
@@ -15,7 +15,7 @@ import python
 import MethodCallOrder
 
 predicate multipleCallsToSuperclassDel(Function meth, Function calledMulti) {
-  multipleCallsToSuperclassMethod(meth, calledMulti, "__sel__")
+  multipleCallsToSuperclassMethod(meth, calledMulti, "__del__")
 }
 
 from Function meth, Function calledMulti