hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: simplify and explain getExplicitlyConverted

Browse Source
This commit is contained in:
Robert Marsh
2020-09-08 13:02:51 -07:00
parent 65cc9888d5
commit 44bdf98217
1 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cpp/ql/src/semmle/code/cpp/exprs/Expr.qll
View File

@@ -453,19 +453,16 @@ class Expr extends StmtParent, @expr {
* cast from B to C. Only (1) and (2) would be included.
*/
Expr getExplicitlyConverted() {
if this.hasConversion()
// For performance, we avoid a full transitive closure over `getConversion`.
// Since there can be several implicit conversions before and after an
// explicit conversion, use `getImplicitlyConverted` to step over them
// cheaply. Then, if there is an explicit conversion following the implict
// conversion sequence, recurse to handle multiple explicit conversions.
if this.getImplicitlyConverted().hasExplicitConversion()
then
if this.hasExplicitConversion()
then
result = this.getConversion().getExplicitlyConverted()
result = this.getImplicitlyConverted().getConversion().getExplicitlyConverted()
else
if this.getImplicitlyConverted().hasExplicitConversion()
then
result = this.getImplicitlyConverted().getConversion().getExplicitlyConverted()
else
result = this
else
result = this
result = this
}
/**