hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

CPP: Back out support for 'SysAllocString', as PointsTo doesn't support the free(pointer-to-pointer) pattern in 'SysReAllocString' leading to unaccaptable FPs.

Browse Source
This commit is contained in:
Geoffrey White
2019-03-21 15:38:10 +00:00
parent fbe584f3e1
commit 444259a9ad
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/src/semmle/code/cpp/commons/Alloc.qll
View File

@@ -48,10 +48,7 @@ predicate allocationFunction(Function f)
name = "HeapReAlloc" or
name = "VirtualAlloc" or
name = "CoTaskMemAlloc" or
name = "CoTaskMemRealloc" or
name = "SysAllocString" or
name = "SysAllocStringByteLen" or
name = "SysAllocStringLen"
name = "CoTaskMemRealloc"
)
)
}
@@ -103,8 +100,7 @@ predicate freeFunction(Function f, int argNum)
(name = "LocalReAlloc" and argNum = 0) or
(name = "GlobalReAlloc" and argNum = 0) or
(name = "HeapReAlloc" and argNum = 2) or
(name = "CoTaskMemRealloc" and argNum = 0) or
(name = "SysReAllocString" and argNum = 0)
(name = "CoTaskMemRealloc" and argNum = 0)
)
)
}