mirror of
https://github.com/github/codeql.git
synced 2025-12-20 10:46:30 +01:00
Apply suggestions from code review
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
This commit is contained in:
@@ -19,7 +19,7 @@ import experimental.dataflow.RemoteFlowSources
|
||||
import DataFlow::PathGraph
|
||||
|
||||
class UnsafeDeserializationConfiguration extends TaintTracking::Configuration {
|
||||
UnsafeDeserializationConfiguration() { this = "Unsafe deserialization configuration" }
|
||||
UnsafeDeserializationConfiguration() { this = "UnsafeDeserializationConfiguration" }
|
||||
|
||||
override predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
|
||||
|
||||
|
||||
@@ -9,7 +9,7 @@ private import experimental.semmle.python.Concepts
|
||||
|
||||
private module Marshal {
|
||||
/** Gets a reference to the `marshal` module. */
|
||||
DataFlow::Node marshal(DataFlow::TypeTracker t) {
|
||||
private DataFlow::Node marshal(DataFlow::TypeTracker t) {
|
||||
t.start() and
|
||||
result = DataFlow::importModule("marshal")
|
||||
or
|
||||
@@ -38,7 +38,7 @@ private module Marshal {
|
||||
|
||||
/**
|
||||
* A call to `marshal.loads`
|
||||
* See https://docs.python.org/2/library/marshal.html#marshal.load
|
||||
* See https://docs.python.org/3/library/marshal.html#marshal.loads
|
||||
*/
|
||||
private class MarshalDeserialization extends DeserializationSink::Range {
|
||||
MarshalDeserialization() {
|
||||
|
||||
Reference in New Issue
Block a user