CPP: Move the 'gets' case.

cpp/ql/src/Likely Bugs/Memory Management/PotentialBufferOverflow.ql

@@ -18,20 +18,6 @@ abstract class PotentiallyDangerousFunctionCall extends FunctionCall {
   abstract string getDescription();
 }
 
-class GetsCall extends PotentiallyDangerousFunctionCall {
-  GetsCall() {
-    this.getTarget().hasName("gets")
-  }
-
-  override predicate isDangerous() {
-    any()
-  }
-
-  override string getDescription() {
-    result = "gets does not guard against buffer overflow"
-  }
-}
-
 class SprintfCall extends PotentiallyDangerousFunctionCall {
   SprintfCall() {
     this.getTarget().hasName("sprintf") or this.getTarget().hasName("vsprintf")

cpp/ql/src/Security/CWE/CWE-676/PotentiallyDangerousFunction.ql

@@ -15,6 +15,9 @@ predicate potentiallyDangerousFunction(Function f, string message) {
   (
     f.getQualifiedName() = "gmtime" and
     message = "Call to gmtime is potentially dangerous"
+  ) or (
+    f.hasName("gets") and
+    message = "gets does not guard against buffer overflow"
   )
 }