hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

use if-then-else rather than nested exists

Browse Source
This commit is contained in:
Sim4n6
2023-02-08 21:46:50 +01:00
parent 9e285020a1
commit 4196230a8a
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
python/ql/src/experimental/Security/UnsafeUnpackQuery.qll
View File

@@ -84,11 +84,9 @@ class UnsafeUnpackingConfig extends TaintTracking::Configuration {
// see wget: https://pypi.org/project/wget/
exists(API::CallNode mcn |
mcn = API::moduleImport("wget").getMember("download").getACall() and
(
source = mcn.getArg(1)
or
source = mcn.getReturn().asSource() and not exists(Node arg | arg = mcn.getArg(1))
)
if exists(Node arg | arg = mcn.getArg(1))
then source = mcn.getArg(1)
else source = mcn.getReturn().asSource()
)
or
// catch the Django uploaded files as a source