hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to use QueryDoc

Browse Source 
Kudos to @erik-krogh for the suggestion.
This commit is contained in:
Tony Torralba
2023-06-20 14:41:45 +02:00
parent 7837959bdf
commit 41534803e5
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
ql/ql/src/queries/style/AndroidIdPrefix.ql
View File

@@ -1,6 +1,6 @@
/**
* @name Android query without android @id prefix
* @description Android queries should include the `android` prefix in their `@id`.
* @description Android queries should include the `android/` prefix in their `@id`.
* @kind problem
* @problem.severity warning
* @id ql/android-id-prefix
@@ -9,10 +9,7 @@
import ql
string getIdProperty(QLDoc doc) {
result = any(string id | id = doc.getContents().splitAt("@") and id.matches("id %"))
}
/** Holds if `t` transitively imports an Android module. */
predicate importsAndroidModule(TopLevel t) {
exists(Import i | t.getAnImport() = i |
i.getImportString().toLowerCase().matches("%android%")
@@ -24,9 +21,9 @@ predicate importsAndroidModule(TopLevel t) {
)
}
from TopLevel t
from QueryDoc d
where
t.getLocation().getFile().getRelativePath().matches("%src/Security/%.ql") and
not getIdProperty(t.getQLDoc()).matches("% java/android/%") and
importsAndroidModule(t)
select t, "This Android query is missing the `android` prefix in its `@id`."
d.getLocation().getFile().getRelativePath().matches("%src/Security/%") and
not d.getQueryId().matches("android/%") and
importsAndroidModule(d.getParent())
select d, "This Android query is missing the `android/` prefix in its `@id`."