From 413f49bba546436a9a9f49df1fd004368f87efe5 Mon Sep 17 00:00:00 2001 From: Rachel Mant Date: Thu, 31 Oct 2019 22:50:44 +0000 Subject: [PATCH] Query cpp/unused-static-variable was producing incorrect results for constexpr variables --- .../src/Best Practices/Unused Entities/UnusedStaticVariables.ql | 1 + 1 file changed, 1 insertion(+) diff --git a/cpp/ql/src/Best Practices/Unused Entities/UnusedStaticVariables.ql b/cpp/ql/src/Best Practices/Unused Entities/UnusedStaticVariables.ql index 26cf42521e5..3ad43998d18 100644 --- a/cpp/ql/src/Best Practices/Unused Entities/UnusedStaticVariables.ql +++ b/cpp/ql/src/Best Practices/Unused Entities/UnusedStaticVariables.ql @@ -21,6 +21,7 @@ from Variable v where v.isStatic() and v.hasDefinition() and + not v.isConstexpr() and not exists(VariableAccess a | a.getTarget() = v) and not v instanceof MemberVariable and not declarationHasSideEffects(v) and