hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 21:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14308 from hmac/hmac-rb-csrf-not-enabled

Browse Source 
Ruby: Add a query for CSRF protection not enabled
This commit is contained in:
Harry Maclean
2024-04-02 11:30:36 +01:00
committed by GitHub
parent 3c8c45872e 806f42ef72
commit 409f46ef7b
17 changed files with 490 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ruby/ql/test/query-tests/security/cwe-352/CSRFProtectionDisabled.expected
View File

@@ -1,5 +1,5 @@
| railsapp/app/controllers/application_controller.rb:5:3:5:22 | call to protect_from_forgery | Potential CSRF vulnerability due to forgery protection being disabled or weakened. |
| railsapp/app/controllers/users_controller.rb:4:3:4:47 | call to skip_before_action | Potential CSRF vulnerability due to forgery protection being disabled or weakened. |
| railsapp/config/application.rb:15:5:15:53 | call to allow_forgery_protection= | Potential CSRF vulnerability due to forgery protection being disabled or weakened. |
| railsapp/config/application.rb:16:5:16:53 | call to allow_forgery_protection= | Potential CSRF vulnerability due to forgery protection being disabled or weakened. |
| railsapp/config/environments/development.rb:5:3:5:51 | call to allow_forgery_protection= | Potential CSRF vulnerability due to forgery protection being disabled or weakened. |
| railsapp/config/environments/production.rb:5:3:5:51 | call to allow_forgery_protection= | Potential CSRF vulnerability due to forgery protection being disabled or weakened. |

1
ruby/ql/test/query-tests/security/cwe-352/CSRFProtectionNotEnabled.expected Normal file
View File

@@ -0,0 +1 @@
| railsapp/app/controllers/alternative_root_controller.rb:1:1:3:3 | AlternativeRootController | Potential CSRF vulnerability due to forgery protection not being enabled. |

1
ruby/ql/test/query-tests/security/cwe-352/CSRFProtectionNotEnabled.qlref Normal file
View File

@@ -0,0 +1 @@
queries/security/cwe-352/CSRFProtectionNotEnabled.ql

3
ruby/ql/test/query-tests/security/cwe-352/railsapp/app/controllers/alternative_root_controller.rb Normal file
View File

@@ -0,0 +1,3 @@
class AlternativeRootController < ActionController::Base
# BAD: no protect_from_forgery call
end

3
ruby/ql/test/query-tests/security/cwe-352/railsapp/app/controllers/subscriptions_controller.rb Normal file
View File

@@ -0,0 +1,3 @@
class SubscriptionsController < AlternativeRootController
protect_from_forgery with: :exception
end

2
ruby/ql/test/query-tests/security/cwe-352/railsapp/app/controllers/tags_controller.rb Normal file
View File

@@ -0,0 +1,2 @@
class TagsController < AlternativeRootController
end

3
ruby/ql/test/query-tests/security/cwe-352/railsapp/config/application.rb
View File

@@ -9,7 +9,8 @@ Bundler.require(*Rails.groups)
module Railsapp
class Application < Rails::Application
# Initialize configuration defaults for originally generated Rails version.
config.load_defaults 6.0
# This defaults version does NOT enable CSRF protection by default.
config.load_defaults 5.1
# BAD: Disabling forgery protection may open the application to CSRF attacks
config.action_controller.allow_forgery_protection = false