hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add feedback from Code review

Browse Source
This commit is contained in:
Alvaro Muñoz
2022-12-07 10:36:44 +01:00
parent 3e92b4c596
commit 407df37a74
1 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
javascript/ql/lib/semmle/javascript/frameworks/Spife.qll
View File

@@ -209,26 +209,25 @@ module Spife {
* route handler.
*/
private class ReplyCall extends API::CallNode {
boolean isDirectReplyCall;
ReplyCall() {
// reply(resp)
this = API::moduleImport(["@npm/spife/reply", "spife/reply"]).getACall()
this = API::moduleImport(["@npm/spife/reply", "spife/reply"]).getACall() and
isDirectReplyCall = true
or
// reply.header(resp, 'foo', 'bar')
this = API::moduleImport(["@npm/spife/reply", "spife/reply"]).getAMember().getACall()
this = API::moduleImport(["@npm/spife/reply", "spife/reply"]).getAMember().getACall() and
isDirectReplyCall = false
}
predicate isDirectReplyCall() {
this = API::moduleImport(["@npm/spife/reply", "spife/reply"]).getACall()
}
predicate isDirectReplyCall() { isDirectReplyCall = true }
/**
* Gets the route handler that provides this response.
*/
RouteHandler getRouteHandler() {
exists(RouteHandler handler |
handler.getAReturn() = this.getReturn().getAValueReachableFromSource() and
result = handler
)
result.getAReturn() = this.getReturn().getAValueReachableFromSource()
}
}
@@ -248,9 +247,7 @@ module Spife {
headerValue = super.getArgument(2)
}
override DataFlow::Node getNameNode() {
result = super.getArgument(1)
}
override DataFlow::Node getNameNode() { result = super.getArgument(1) }
override RouteHandler getRouteHandler() { result = ReplyCall.super.getRouteHandler() }
}
@@ -380,14 +377,14 @@ module Spife {
* An object passed to the `template` method of the reply object.
*/
private class TemplateObjectInput extends DataFlow::Node {
TemplateCall call;
ReplyCall call;
TemplateObjectInput() { this = call.(ReplyCall).getArgument(1) }
TemplateObjectInput() { this = call.getArgument(1) }
/**
* Gets the route handler that uses this object.
*/
RouteHandler getRouteHandler() { result = call.(ReplyCall).getRouteHandler() }
RouteHandler getRouteHandler() { result = call.getRouteHandler() }
}
/**