hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 05:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: respond to PR comments

Browse Source
This commit is contained in:
Robert Marsh
2019-10-02 11:21:10 -07:00
parent 68c38ba34a
commit 4018ed67a6
7 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/Critical/OverflowCalculated.ql
View File

@@ -36,7 +36,7 @@ predicate spaceProblem(FunctionCall append, string msg) {
buffer.getAnAccess() = strlen.getStringExpr() and
(
insert.getTarget().hasGlobalOrStdName("strcpy") or
insert.getTarget().hasGlobalName("strncpy")
insert.getTarget().hasGlobalOrStdName("strncpy")
) and
(
append.getTarget().hasGlobalOrStdName("strcat") or

2
cpp/ql/src/Critical/OverflowStatic.ql
View File

@@ -58,7 +58,7 @@ predicate overflowOffsetInLoop(BufferAccess bufaccess, string msg) {
}
predicate bufferAndSizeFunction(Function f, int buf, int size) {
f.hasGlobalOrStdName("read") and buf = 1 and size = 2
f.hasGlobalName("read") and buf = 1 and size = 2
or
f.hasGlobalOrStdName("fgets") and buf = 0 and size = 1
or