hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 02:35:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments.

Browse Source
This commit is contained in:
Max Schaefer
2021-02-25 10:48:23 +00:00
parent 2e252ba3e4
commit 3fe249f25c
4 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/test/library-tests/DOM/Customizations.expected
View File

@@ -1,10 +1,10 @@
test_documentRef
| customization.js:2:13:2:31 | customGetDocument() |
| event-handler-receiver.js:1:1:1:8 | document |
| event-handler-receiver.js:5:1:5:8 | document |
| nameditems.js:1:1:1:8 | document |
test_locationRef
| customization.js:3:3:3:14 | doc.location |
| event-handler-receiver.js:2:49:2:56 | location |
test_domValueRef
| customization.js:4:3:4:20 | doc.getElementById |
| customization.js:4:3:4:28 | doc.get ... 'test') |
@@ -13,6 +13,10 @@ test_domValueRef
| event-handler-receiver.js:1:1:1:32 | documen ... my-id') |
| event-handler-receiver.js:1:44:1:43 | this |
| event-handler-receiver.js:2:3:2:17 | this.parentNode |
| event-handler-receiver.js:5:1:5:23 | documen ... entById |
| event-handler-receiver.js:5:1:5:32 | documen ... my-id') |
| event-handler-receiver.js:5:60:5:59 | this |
| event-handler-receiver.js:6:3:6:17 | this.parentNode |
| nameditems.js:1:1:1:23 | documen ... entById |
| nameditems.js:1:1:1:30 | documen ... ('foo') |
| nameditems.js:1:1:2:19 | documen ... em('x') |

2
javascript/ql/test/library-tests/DOM/event-handler-receiver.html
View File

@@ -3,4 +3,4 @@
<body>
<button onclick="alert(this.tagName);">Click me</button>
</body>
</html>
</html>

8
javascript/ql/test/library-tests/DOM/event-handler-receiver.js
View File

@@ -1,3 +1,7 @@
document.getElementById('my-id').onclick = function() {
this.parentNode.innerHTML = '<h2><a href="' + location.href + '">A link</a></h2>'; // NOT OK
document.getElementById('my-id').onclick = function () {
this.parentNode.innerHTML = '<b>hello</b>'; // `this` is a DOM element
};
document.getElementById('my-id').addEventListener("click", function (ev) {
this.parentNode.innerHTML = '<b>hello</b>'; // `this` is a DOM element
});