hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-23 20:26:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

renamed "isDelegating" to "is_delegating"

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-09-04 11:51:50 +02:00
parent ba600acd5e
commit 3fb561d72b
8 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/extractor/src/com/semmle/js/extractor/ASTExtractor.java
View File

@@ -810,7 +810,7 @@ public class ASTExtractor {
public Label visit(YieldExpression nd, Context c) { public Label visit(YieldExpression nd, Context c) {
Label key = super.visit(nd, c); Label key = super.visit(nd, c);
visit(nd.getArgument(), key, 0); visit(nd.getArgument(), key, 0);
if (nd.isDelegating()) trapwriter.addTuple("isDelegating", key); if (nd.isDelegating()) trapwriter.addTuple("is_delegating", key);
return key; return key;
} }

2
javascript/extractor/tests/es2015/output/trap/delegating_yield.js.trap
View File

@@ -155,7 +155,7 @@ literals("g","g",#20049)
#20050=@"var;{g};{#20000}" #20050=@"var;{g};{#20000}"
variables(#20050,"g",#20000) variables(#20050,"g",#20000)
bind(#20049,#20050) bind(#20049,#20050)
isDelegating(#20045) is_delegating(#20045)
#20051=* #20051=*
entry_cfg_node(#20051,#20001) entry_cfg_node(#20051,#20001)
#20052=@"loc,{#10000},1,1,1,0" #20052=@"loc,{#10000},1,1,1,0"

2
javascript/extractor/tests/flow/output/trap/explicitTypeParameters.js.trap
View File

@@ -564,7 +564,7 @@ literals("x","x",#20198)
#20199=@"var;{x};{#20000}" #20199=@"var;{x};{#20000}"
variables(#20199,"x",#20000) variables(#20199,"x",#20000)
bind(#20198,#20199) bind(#20198,#20199)
isDelegating(#20192) is_delegating(#20192)
#20200=* #20200=*
stmts(#20200,2,#20001,3,"f4<T6>(v1);") stmts(#20200,2,#20001,3,"f4<T6>(v1);")
hasLocation(#20200,#20013) hasLocation(#20200,#20013)

5
javascript/ql/src/semmle/javascript/Aliases.qll
View File

@@ -130,3 +130,8 @@ deprecated predicate exprContainers(ExprOrType expr, StmtContainer container) {
* Use `ArrayExpr#getSize()` instead. * Use `ArrayExpr#getSize()` instead.
*/ */
deprecated predicate arraySize(Expr ae, int sz) { array_size(ae, sz) } deprecated predicate arraySize(Expr ae, int sz) { array_size(ae, sz) }
/**
* Alias for the predicate `is_delegating` defined in the .dbscheme.
* Use `YieldExpr#isDelegating()` instead.
*/
deprecated predicate isDelegating(YieldExpr yield) { is_delegating(yield) }

2
javascript/ql/src/semmle/javascript/Expr.qll
View File

@@ -2128,7 +2128,7 @@ class YieldExpr extends @yieldexpr, Expr {
Expr getOperand() { result = getChildExpr(0) } Expr getOperand() { result = getChildExpr(0) }
/** Holds if this is a `yield*` expression. */ /** Holds if this is a `yield*` expression. */
predicate isDelegating() { isDelegating(this) } predicate isDelegating() { is_delegating(this) }
override predicate isImpure() { any() } override predicate isImpure() { any() }

2
javascript/ql/src/semmlecode.javascript.dbscheme
View File

@@ -226,7 +226,7 @@ expr_containers (unique int expr: @exprortype ref,
array_size (unique int ae: @arraylike ref, array_size (unique int ae: @arraylike ref,
int sz: int ref); int sz: int ref);
isDelegating (int yield: @yieldexpr ref); is_delegating (int yield: @yieldexpr ref);
@exprorstmt = @expr | @stmt; @exprorstmt = @expr | @stmt;
@exprortype = @expr | @typeexpr; @exprortype = @expr | @typeexpr;

2
javascript/ql/src/semmlecode.javascript.dbscheme.stats
View File

@@ -11471,7 +11471,7 @@
</dependencies> </dependencies>
</relation> </relation>
<relation> <relation>
<name>isDelegating</name> <name>is_delegating</name>
<cardinality>4</cardinality> <cardinality>4</cardinality>
<columnsizes> <columnsizes>
<e> <e>

2
javascript/upgrades/c73fbfca57f3d593b9ff50c6aa3a886d6888efec/upgrade.properties
View File

@@ -26,3 +26,5 @@ expr_containers.rel: reorder exprContainers.rel(int expr, int container) expr co
exprContainers.rel: delete exprContainers.rel: delete
array_size.rel: reorder arraySize.rel(int ae, int sz) ae sz array_size.rel: reorder arraySize.rel(int ae, int sz) ae sz
arraySize.rel: delete arraySize.rel: delete
is_delegating.rel: reorder isDelegating.rel(int yield) yield
isDelegating.rel: delete