C++: Address review.

This commit is contained in:
Cornelius Riemenschneider
2021-02-16 11:55:03 +00:00
committed by GitHub
parent 79e3bf80c3
commit 3f17171f13
2 changed files with 3 additions and 3 deletions

View File

@@ -142,9 +142,9 @@ class Declaration extends Locatable, @declaration {
/**
* Holds if this declaration has the given name in the global namespace,
* the `std` namespace or the `bsl` namespace.
* We treat `std` and `bsl` as the same in a bunch of our models.
* We treat `std` and `bsl` as the same in some of our models.
*/
predicate hasGlobalOrStdishName(string name) {
predicate hasGlobalOrStdOrBslName(string name) {
this.hasGlobalName(name)
or
this.hasQualifiedName("std", "", name)

View File

@@ -15,7 +15,7 @@ import semmle.code.cpp.models.interfaces.SideEffect
private class MemsetFunction extends ArrayFunction, DataFlowFunction, AliasFunction,
SideEffectFunction {
MemsetFunction() {
this.hasGlobalOrStdishName("memset")
this.hasGlobalOrStdOrBslName("memset")
or
this.hasGlobalOrStdName("wmemset")
or