hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-03-06 15:49:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: Identify ActionController::API

Browse Source 
`ActionController::API < ActionController::Base` is a base controller
class, so we should recognise it as such.
This commit is contained in:
Harry Maclean
2023-10-13 11:52:39 +01:00
parent 32b775fdc3
commit 3ee425cc47
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ruby/ql/lib/codeql/ruby/frameworks/ActionController.qll
View File

@@ -100,11 +100,11 @@ private DataFlow::ConstRef actionControllerBaseClass() {
// In Rails applications `ApplicationController` typically extends `ActionController::Base`, but we
// treat it separately in case the `ApplicationController` definition is not in the database.
DataFlow::getConstant("ActionController").getConstant("Base"),
// ActionController::Metal technically doesn't contain all of the
// ActionController::Metal and ActionController::API technically don't contain all of the
// methods available in Base, such as those for rendering views.
// However we prefer to be over-sensitive in this case in order to find
// more results.
DataFlow::getConstant("ActionController").getConstant("Metal")
// However we prefer to be over-sensitive in this case in order to find more results.
DataFlow::getConstant("ActionController").getConstant("Metal"),
DataFlow::getConstant("ActionController").getConstant("API")
]
}