hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 09:13:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Add 'InheritanceConversionInstruction' to the list of instructions that set 'certain = false' in 'explicitWrite'.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-11-02 13:02:46 +00:00
parent 56cabb8f46
commit 3e6ac74d73
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll
View File

@@ -315,11 +315,14 @@ predicate explicitWrite(boolean certain, Instruction instr, Instruction address)
exists(StoreInstruction store | exists(StoreInstruction store |
store = instr and addressFlowTC(address, store.getDestinationAddress()) store = instr and addressFlowTC(address, store.getDestinationAddress())
| |
// Set `certain = false` if the address is derived from any instructions that prevents us from
// concluding that the entire variable is overridden.
if if
addressFlowTC(any(Instruction i | addressFlowTC(any(Instruction i |
i instanceof FieldAddressInstruction or i instanceof FieldAddressInstruction or
i instanceof PointerArithmeticInstruction or i instanceof PointerArithmeticInstruction or
i instanceof LoadInstruction i instanceof LoadInstruction or
i instanceof InheritanceConversionInstruction
), store.getDestinationAddress()) ), store.getDestinationAddress())
then certain = false then certain = false
else certain = true else certain = true