hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 05:05:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2431 from tausbn/python-cyclic-import-future-annotations

Browse Source 
Python: Account for non-evaluation of annotations in cyclic imports.
This commit is contained in:
Rasmus Wriedt Larsen
2019-11-27 13:31:53 +01:00
committed by GitHub
parent 4916bed9cd 036e0f75c8
commit 3e5e14a14b
7 changed files with 67 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
python/ql/test/query-tests/Imports/cyclic-module-annotations-fp/ModuleLevelCyclicImport.expected Normal file
View File

@@ -0,0 +1,2 @@
| module3.py:8:23:8:33 | Attribute | 'Bar' may not be defined if module $@ is imported before module $@, as the $@ of Bar occurs after the cyclic $@ of module3. | module4.py:0:0:0:0 | Module module4 | module4 | module3.py:0:0:0:0 | Module module3 | module3 | module4.py:7:7:7:9 | ControlFlowNode for Bar | definition | module4.py:4:1:4:14 | Import | import |
| module4.py:8:30:8:40 | Attribute | 'Foo' may not be defined if module $@ is imported before module $@, as the $@ of Foo occurs after the cyclic $@ of module4. | module3.py:0:0:0:0 | Module module3 | module3 | module4.py:0:0:0:0 | Module module4 | module4 | module3.py:7:7:7:9 | ControlFlowNode for Foo | definition | module3.py:4:1:4:14 | Import | import |

1
python/ql/test/query-tests/Imports/cyclic-module-annotations-fp/ModuleLevelCyclicImport.qlref Normal file
View File

@@ -0,0 +1 @@
Imports/ModuleLevelCyclicImport.ql

10
python/ql/test/query-tests/Imports/cyclic-module-annotations-fp/module1.py Normal file
View File

@@ -0,0 +1,10 @@
from __future__ import annotations
import dataclasses
import typing
import module2
@dataclasses.dataclass()
class Foo:
bars: typing.List[module2.Bar]

11
python/ql/test/query-tests/Imports/cyclic-module-annotations-fp/module2.py Normal file
View File

@@ -0,0 +1,11 @@
from __future__ import annotations
import dataclasses
import typing
import module1
@dataclasses.dataclass()
class Bar:
def is_in_foo(self, foo: module1.Foo):
return self in foo.bars

8
python/ql/test/query-tests/Imports/cyclic-module-annotations-fp/module3.py Normal file
View File

@@ -0,0 +1,8 @@
import dataclasses
import typing
import module4
@dataclasses.dataclass()
class Foo:
bars: typing.List[module4.Bar]

9
python/ql/test/query-tests/Imports/cyclic-module-annotations-fp/module4.py Normal file
View File

@@ -0,0 +1,9 @@
import dataclasses
import typing
import module3
@dataclasses.dataclass()
class Bar:
def is_in_foo(self, foo: module3.Foo):
return self in foo.bars