hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-19 05:37:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Re-introduce the source model kind validation and allow sql kind as well.

Browse Source
This commit is contained in:
Michael Nebel
2023-05-01 15:00:38 +02:00
parent 7d8c0d368a
commit 3dfd93dbaf
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll
View File

@@ -286,13 +286,13 @@ module ModelValidation {
not kind.matches("qltest%") and
result = "Invalid kind \"" + kind + "\" in sink model."
)
// All source kinds are supported, but some may not be used in this query.
// or
// exists(string kind | sourceModel(_, _, _, _, _, _, _, kind, _) |
// not ConfiguredExtensions::supportedSourceKind(kind) and
// not kind.matches("qltest%") and
// result = "Invalid kind \"" + kind + "\" in source model."
// )
or
exists(string kind | sourceModel(_, _, _, _, _, _, _, kind, _) |
not kind =
["remote", "sql", "contentprovider", "android-widget", "android-external-storage-dir"] and
not kind.matches("qltest%") and
result = "Invalid kind \"" + kind + "\" in source model."
)
}
private string getInvalidModelSignature() {