hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 21:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

More tests for RmiUnsafeDeserialization

Browse Source
This commit is contained in:
Artem Smotrakov
2021-04-15 22:13:19 +03:00
parent ec6186a1c5
commit 3d20330a92
1 changed files with 35 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
java/ql/test/experimental/query-tests/security/CWE-502/RmiUnsafeDeserialization.java
View File

@@ -1,3 +1,4 @@
import java.io.ObjectInputStream;
import java.rmi.Naming;
import java.rmi.Remote;
import java.rmi.RemoteException;
@@ -10,15 +11,47 @@ public class RmiUnsafeDeserialization {
public static void testRegistryBindWithObjectParameter() throws Exception {
Registry registry = LocateRegistry.createRegistry(1099);
registry.bind("test", new RemoteObjectWithObject());
registry.rebind("test", new RemoteObjectWithObject());
}
// GOOD (bind a remote object that has methods that takes safe parameters)
public static void testRegistryBindWithIntParameter() throws Exception {
Registry registry = LocateRegistry.createRegistry(1099);
registry.bind("test", new SafeRemoteObject());
registry.rebind("test", new SafeRemoteObject());
}
// BAD (bind a remote object that has a vulnerable method that takes Object)
public static void testNamingBindWithObjectParameter() throws Exception {
Naming.bind("test", new RemoteObjectWithObject());
Naming.rebind("test", new RemoteObjectWithObject());
}
// GOOD (bind a remote object that has methods that takes safe parameters)
public static void testNamingBindWithIntParameter() throws Exception {
Naming.bind("test", new SafeRemoteObject());
Naming.rebind("test", new SafeRemoteObject());
}
}
interface RemoteObjectWithObjectInterface extends Remote {
void take(Object obj) throws RemoteException;
}
class RemoteObjectWithObject implements RemoteObjectWithObjectInterface {
public void take(Object obj) throws RemoteException {}
}
interface SafeRemoteObjectInterface extends Remote {
void take(int n) throws RemoteException;
void take(double n) throws RemoteException;
void take(String s) throws RemoteException;
void take(ObjectInputStream ois) throws RemoteException;
}
class SafeRemoteObject implements SafeRemoteObjectInterface {
public void take(int n) throws RemoteException {}
public void take(double n) throws RemoteException {}
public void take(String s) throws RemoteException {}
public void take(ObjectInputStream ois) throws RemoteException {}
}