hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-Authored-By: Jonas Jensen <jbj@github.com>
This commit is contained in:
Mathias Vorreiter Pedersen
2020-04-15 14:01:49 +02:00
committed by GitHub
parent a2fbe9e9da
commit 3d0ac53266
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/src/Critical/Negativity.qll
View File

@@ -129,7 +129,7 @@ predicate errorCondition(Variable v, Expr cond) {
* - `cond` checks that `v` is not equal to `-1`, or
* - `cond` checks that `v` is greater than or equal than `0`, or
* - `cond` checks that `v` is greater than `-1`, or
* - `cond` checks that `v` is not some common success value (see `errorCondition`).
* - `cond` checks that `v` is not some common error value (see `errorCondition`).
*/
predicate successCondition(Variable v, Expr cond) {
exists(NEExpr ne |
@@ -198,7 +198,7 @@ predicate checkedError(Variable v, ControlFlowNode n) {
/**
* Holds if the current value of the variable `v` at control-flow node
* `n` may have been checked against a common set of *error* values.
* `n` may have been checked against a common set of *success* values.
*/
predicate checkedSuccess(Variable v, ControlFlowNode n) {
successSuccessor(v, n)