hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adds some debugging changes.

Browse Source
This commit is contained in:
Rebecca Valentine
2020-02-12 19:29:42 -08:00
parent 178acc85b9
commit 3ce250b2cf
2 changed files with 64 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
python/ql/src/Expressions/ExpectedMappingForFormatString.ql
View File

@@ -13,7 +13,37 @@
import python
import semmle.python.strings
/* modernized query
from Expr e, ClassValue t
where exists(BinaryExpr b | b.getOp() instanceof Mod and format_string(b.getLeft()) and e = b.getRight() and
mapping_format(b.getLeft()) and e.pointsTo(_, t, _) and not t.isMapping())
select e, "Right hand side of a % operator must be a mapping, not class $@.", t, t.getName()
select e, "Right hand side of a % operator must be a mapping, not class $@.", t, t.getName()
//*/
/* original query
from Expr e, ClassObject t
where exists(BinaryExpr b | b.getOp() instanceof Mod and format_string(b.getLeft()) and e = b.getRight() and
mapping_format(b.getLeft()) and e.refersTo(_, t, _) and not t.isMapping())
select e, "Right hand side of a % operator must be a mapping, not class $@.", t, t.getName()
//*/
//* debug query
from Expr e, ClassValue t, string s
where any()
and exists(BinaryExpr b | any()
and b.getOp() instanceof Mod
and format_string(b.getLeft())
and e = b.getRight()
and mapping_format(b.getLeft())
and e.pointsTo().getClass() = t
//and not t.isMapping()
)
and if t.hasAttribute("__getitem__") then s = "yes" else s = "no"
select
e
, "Right hand side of a % operator must be a mapping, not class $@."
, t
, t.getName()
, s
, s
//*/