hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 02:35:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup from review feedback

Browse Source
This commit is contained in:
Jonathan Leitschuh
2022-02-15 10:23:52 -05:00
parent 39828fd596
commit 3cdfc00542
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/lib/semmle/code/java/frameworks/apache/Lang.qll
View File

@@ -39,10 +39,10 @@ private class ApacheStrBuilderFluentMethod extends FluentMethod {
}
/**
* The class ``org.apache.commons.lang.SystemUtils` or `org.apache.commons.lang3.SystemUtils`.
* The class `org.apache.commons.lang.SystemUtils` or `org.apache.commons.lang3.SystemUtils`.
*/
class ApacheSystemUtilis extends Class {
ApacheSystemUtilis() {
class ApacheSystemUtils extends Class {
ApacheSystemUtils() {
this.hasQualifiedName(["org.apache.commons.lang", "org.apache.commons.lang3"], "SystemUtils")
}
}

8
java/ql/lib/semmle/code/java/os/OSCheck.qll
View File

@@ -9,12 +9,12 @@ private import semmle.code.java.dataflow.DataFlow
private import semmle.code.java.StringCheck
/**
* A complimentatry guard that checks if the current platform is Windows.
* A guard that checks if the current platform is Windows.
*/
abstract class IsWindowsGuard extends Guard { }
/**
* A complimentatry guard that checks if the current platform is unix or unix-like.
* A guard that checks if the current platform is unix or unix-like.
*/
abstract class IsUnixGuard extends Guard { }
@@ -53,7 +53,7 @@ private class IsUnixFromSystemProp extends IsUnixGuard instanceof MethodAccess {
private predicate isOsFromApacheCommons(FieldAccess fa, string fieldName) {
exists(Field f | f = fa.getField() |
f.getDeclaringType() instanceof ApacheSystemUtilis and
f.getDeclaringType() instanceof ApacheSystemUtils and
f.hasName(fieldName)
)
}
@@ -63,7 +63,7 @@ private class IsWindowsFromApacheCommons extends IsWindowsGuard instanceof Field
}
private class IsUnixFromApacheCommons extends IsUnixGuard instanceof FieldAccess {
IsUnixFromApacheCommons() { isOsFromApacheCommons(this, ["IS_OS_UNIX"]) }
IsUnixFromApacheCommons() { isOsFromApacheCommons(this, "IS_OS_UNIX") }
}
/**