hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update ElectronShellOpenExternalSink location

Browse Source 
Move the class ElectronShellOpenExternalSink to
ClientSideUrlRedirect.qll. It's been to be a more appropriate location.
This commit is contained in:
toufik-airane
2020-10-23 17:39:03 +02:00
parent e87790b828
commit 3ccdc2c518
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirect.qll
View File

@@ -60,4 +60,15 @@ module ClientSideUrlRedirect {
guard instanceof HostnameSanitizerGuard
}
}
/**
* Improper use of openExternal can be leveraged to compromise the user's host.
* When openExternal is used with untrusted content, it can be leveraged to execute arbitrary commands.
*/
class ElectronShellOpenExternalSink extends Sink {
ElectronShellOpenExternalSink() {
this =
DataFlow::moduleMember("electron", "shell").getAMemberCall("openExternal").getArgument(0)
}
}
}

13
javascript/ql/src/semmle/javascript/security/dataflow/CodeInjectionCustomizations.qll
View File

@@ -138,15 +138,4 @@ module CodeInjection {
API::moduleImport("module").getInstance().getMember("_compile").getACall().getArgument(0)
}
}
/**
* Improper use of openExternal can be leveraged to compromise the user's host.
* When openExternal is used with untrusted content, it can be leveraged to execute arbitrary commands.
*/
class ElectronShellOpenExternalSink extends Sink {
ElectronShellOpenExternalSink() {
this =
DataFlow::moduleMember("electron", "shell").getAMemberCall("openExternal").getArgument(0)
}
}
}
}