hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Teach InvalidExport to never flag module.exports = exports = ... and similar.

Browse Source 
This was previously flagged if `exports` wasn't used any further. While it's true that the assignment to `exports` is redundant in this case, the assignment is also flagged by DeadStorOfLocal, so there is no point in InvalidExport flagging it as well.
This commit is contained in:
Max Schaefer
2019-03-04 09:50:02 +00:00
parent c49c23068a
commit 3cabc12be3
8 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javascript/ql/src/NodeJS/InvalidExport.ql
View File

@@ -41,12 +41,8 @@ from Assignment assgn, Variable exportsVar, DataFlow::Node exportsVal
where
exportsAssign(assgn, exportsVar, exportsVal) and
not exists(exportsVal.getAPredecessor()) and
not (
// this is OK if `exportsVal` flows into `module.exports`
moduleExportsAssign(_, exportsVal) and
// however, if there are no further uses of `exports` the assignment is useless anyway
strictcount(exportsVar.getAnAccess()) > 1
) and
// this is OK if `exportsVal` flows into `module.exports`
not moduleExportsAssign(_, exportsVal) and
// export assignments do work in closure modules
not assgn.getTopLevel() instanceof Closure::ClosureModule
select assgn, "Assigning to 'exports' does not export anything."

2
javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/DeadStoreOfLocal.expected
View File

@@ -1,6 +1,8 @@
| overload.ts:10:12:10:14 | baz | This definition of baz is useless, since its value is never read. |
| tst2.js:26:9:26:14 | x = 23 | This definition of x is useless, since its value is never read. |
| tst2.js:28:9:28:14 | x = 42 | This definition of x is useless, since its value is never read. |
| tst3.js:2:1:2:36 | exports ... a: 23 } | This definition of exports is useless, since its value is never read. |
| tst3b.js:2:18:2:36 | exports = { a: 23 } | This definition of exports is useless, since its value is never read. |
| tst.js:6:2:6:7 | y = 23 | This definition of y is useless, since its value is never read. |
| tst.js:13:6:13:11 | a = 23 | This definition of a is useless, since its value is never read. |
| tst.js:13:14:13:19 | a = 42 | This definition of a is useless, since its value is never read. |

2
javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst3.js Normal file
View File

@@ -0,0 +1,2 @@
// NOT OK
exports = module.exports = { a: 23 };

2
javascript/ql/test/query-tests/Declarations/DeadStoreOfLocal/tst3b.js Normal file
View File

@@ -0,0 +1,2 @@
// NOT OK
module.exports = exports = { a: 23 };

1
javascript/ql/test/query-tests/NodeJS/InvalidExport/InvalidExport.expected
View File

@@ -1,3 +1,2 @@
| tst3.js:2:1:2:36 | exports ... a: 23 } | Assigning to 'exports' does not export anything. |
| tst5.js:3:1:3:12 | exports = {} | Assigning to 'exports' does not export anything. |
| tst.js:2:1:2:12 | exports = 56 | Assigning to 'exports' does not export anything. |

2
javascript/ql/test/query-tests/NodeJS/InvalidExport/tst3.js
View File

@@ -1,2 +1,2 @@
// NOT OK: useless assignment
// OK: useless assignment flagged by other query
exports = module.exports = { a: 23 };

2
javascript/ql/test/query-tests/NodeJS/InvalidExport/tst3b.js Normal file
View File

@@ -0,0 +1,2 @@
// OK: useless assignment flagged by other query
module.exports = exports = { a: 23 };