hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-28 21:03:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: Minor refactor.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2019-10-07 16:18:48 +02:00
parent f8123679a1
commit 3c4e877913
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
View File

@@ -312,18 +312,15 @@ class ConstantBooleanExprNode extends ArgumentNode, ExprNode {
cached
predicate isUnreachableInCall(Node n, DataFlowCall call) {
exists(
ExplicitParameterNode paramNode, ConstantBooleanExprNode arg, BasicBlock bb,
SsaImplicitInit varInit, Guard guard
ExplicitParameterNode paramNode, ConstantBooleanExprNode arg, SsaImplicitInit param, Guard guard
|
// get argument and parameter for this call
// get constant bool argument and parameter for this call
viableParamArg(call, paramNode, arg) and
// get the ssa variable definition for this parameter
varInit.isParameterDefinition(paramNode.getParameter()) and
param.isParameterDefinition(paramNode.getParameter()) and
// which is used in a guard
varInit.getAUse() = guard and
// which controls that bb is not active
guard.controls(bb, arg.getBooleanValue().booleanNot()) and
// and the node we pass in is in this bb
bb.getANode() = n.asExpr()
param.getAUse() = guard and
// which controls `n` with the opposite value of `arg`
guard.controls(n.asExpr().getBasicBlock(), arg.getBooleanValue().booleanNot())
)
}