From 3c36a9e308845efb134e7ce39ce09c3370a67fd4 Mon Sep 17 00:00:00 2001 From: Owen Mansel-Chan Date: Thu, 5 Mar 2026 15:47:53 +0000 Subject: [PATCH] Correctly deal with generic types --- .../lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll index 2f797ac5da0..f90910b319e 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll @@ -241,8 +241,10 @@ module ModelValidation { string getIncorrectConstructorSummaryOutput() { exists(string namespace, string type, string name, string output | + type = name or + type = name + "<" + any(string s) + | summaryModel(namespace, type, _, name, _, _, _, output, _, _, _) and - type = name and output.matches("ReturnValue%") and result = "Constructor model for " + namespace + "." + type +