From 3b0bd3bc0f46438b8d4fbb84555be26b9dc1d681 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Fri, 1 Apr 2022 11:31:31 +0100 Subject: [PATCH] Improve wording --- .../semmle/code/cpp/dataflow/internal/DataFlowImpl.qll | 8 +++----- .../semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll | 8 +++----- .../semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll | 8 +++----- .../semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll | 8 +++----- .../code/cpp/dataflow/internal/DataFlowImplLocal.qll | 8 +++----- .../internal/tainttracking1/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking2/TaintTrackingImpl.qll | 8 +++----- .../semmle/code/cpp/ir/dataflow/internal/DataFlowImpl.qll | 8 +++----- .../code/cpp/ir/dataflow/internal/DataFlowImpl2.qll | 8 +++----- .../code/cpp/ir/dataflow/internal/DataFlowImpl3.qll | 8 +++----- .../code/cpp/ir/dataflow/internal/DataFlowImpl4.qll | 8 +++----- .../internal/tainttracking1/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking2/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking3/TaintTrackingImpl.qll | 8 +++----- .../semmle/code/csharp/dataflow/internal/DataFlowImpl.qll | 8 +++----- .../code/csharp/dataflow/internal/DataFlowImpl2.qll | 8 +++----- .../code/csharp/dataflow/internal/DataFlowImpl3.qll | 8 +++----- .../code/csharp/dataflow/internal/DataFlowImpl4.qll | 8 +++----- .../code/csharp/dataflow/internal/DataFlowImpl5.qll | 8 +++----- .../internal/tainttracking1/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking2/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking3/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking4/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking5/TaintTrackingImpl.qll | 8 +++----- .../semmle/code/java/dataflow/internal/DataFlowImpl.qll | 8 +++----- .../semmle/code/java/dataflow/internal/DataFlowImpl2.qll | 8 +++----- .../semmle/code/java/dataflow/internal/DataFlowImpl3.qll | 8 +++----- .../semmle/code/java/dataflow/internal/DataFlowImpl4.qll | 8 +++----- .../semmle/code/java/dataflow/internal/DataFlowImpl5.qll | 8 +++----- .../semmle/code/java/dataflow/internal/DataFlowImpl6.qll | 8 +++----- .../dataflow/internal/DataFlowImplForOnActivityResult.qll | 8 +++----- .../dataflow/internal/DataFlowImplForSerializability.qll | 8 +++----- .../internal/tainttracking1/TaintTrackingImpl.qll | 8 +++----- .../internal/tainttracking2/TaintTrackingImpl.qll | 8 +++----- .../semmle/python/dataflow/new/internal/DataFlowImpl.qll | 8 +++----- .../semmle/python/dataflow/new/internal/DataFlowImpl2.qll | 8 +++----- .../semmle/python/dataflow/new/internal/DataFlowImpl3.qll | 8 +++----- .../semmle/python/dataflow/new/internal/DataFlowImpl4.qll | 8 +++----- .../new/internal/tainttracking1/TaintTrackingImpl.qll | 8 +++----- .../new/internal/tainttracking2/TaintTrackingImpl.qll | 8 +++----- .../new/internal/tainttracking3/TaintTrackingImpl.qll | 8 +++----- .../new/internal/tainttracking4/TaintTrackingImpl.qll | 8 +++----- .../ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl.qll | 8 +++----- .../lib/codeql/ruby/dataflow/internal/DataFlowImpl2.qll | 8 +++----- .../ruby/dataflow/internal/DataFlowImplForLibraries.qll | 8 +++----- .../internal/tainttracking1/TaintTrackingImpl.qll | 8 +++----- .../tainttrackingforlibraries/TaintTrackingImpl.qll | 8 +++----- 47 files changed, 141 insertions(+), 235 deletions(-) diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl.qll +++ b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll +++ b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll +++ b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll +++ b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplLocal.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplLocal.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplLocal.qll +++ b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplLocal.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll +++ b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll +++ b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl2.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl2.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl2.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl2.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl3.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl3.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl3.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl3.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl4.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl4.qll index 5fb07c2b751..8ad1036834c 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl4.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl4.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking1/TaintTrackingImpl.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking1/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking1/TaintTrackingImpl.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking1/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking2/TaintTrackingImpl.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking2/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking2/TaintTrackingImpl.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking2/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking3/TaintTrackingImpl.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking3/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking3/TaintTrackingImpl.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/tainttracking3/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl.qll index 5fb07c2b751..8ad1036834c 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl2.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl2.qll index 5fb07c2b751..8ad1036834c 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl2.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl2.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl3.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl3.qll index 5fb07c2b751..8ad1036834c 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl3.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl3.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl4.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl4.qll index 5fb07c2b751..8ad1036834c 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl4.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl4.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl5.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl5.qll index 5fb07c2b751..8ad1036834c 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl5.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl5.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking1/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking2/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking3/TaintTrackingImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking3/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking3/TaintTrackingImpl.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking3/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking4/TaintTrackingImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking4/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking4/TaintTrackingImpl.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking4/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking5/TaintTrackingImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking5/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking5/TaintTrackingImpl.qll +++ b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/tainttracking5/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl2.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl2.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl2.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl2.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl3.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl3.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl3.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl3.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl4.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl4.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl4.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl4.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl5.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl5.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl5.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl5.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl6.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl6.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl6.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl6.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForOnActivityResult.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForOnActivityResult.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForOnActivityResult.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForOnActivityResult.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForSerializability.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForSerializability.qll index 5fb07c2b751..8ad1036834c 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForSerializability.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplForSerializability.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking1/TaintTrackingImpl.qll b/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking1/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking1/TaintTrackingImpl.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking1/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking2/TaintTrackingImpl.qll b/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking2/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking2/TaintTrackingImpl.qll +++ b/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking2/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl.qll index 5fb07c2b751..8ad1036834c 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl2.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl2.qll index 5fb07c2b751..8ad1036834c 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl2.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl2.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl3.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl3.qll index 5fb07c2b751..8ad1036834c 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl3.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl3.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl4.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl4.qll index 5fb07c2b751..8ad1036834c 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl4.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl4.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking1/TaintTrackingImpl.qll b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking1/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking1/TaintTrackingImpl.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking1/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking2/TaintTrackingImpl.qll b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking2/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking2/TaintTrackingImpl.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking2/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking3/TaintTrackingImpl.qll b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking3/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking3/TaintTrackingImpl.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking3/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking4/TaintTrackingImpl.qll b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking4/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking4/TaintTrackingImpl.qll +++ b/python/ql/lib/semmle/python/dataflow/new/internal/tainttracking4/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl.qll index 5fb07c2b751..8ad1036834c 100644 --- a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl.qll +++ b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl2.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl2.qll index 5fb07c2b751..8ad1036834c 100644 --- a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl2.qll +++ b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImpl2.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImplForLibraries.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImplForLibraries.qll index 5fb07c2b751..8ad1036834c 100644 --- a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImplForLibraries.qll +++ b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowImplForLibraries.qll @@ -112,15 +112,13 @@ abstract class Configuration extends string { predicate isBarrierGuard(BarrierGuard guard, FlowState state) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. */ predicate isAdditionalFlowStep(Node node1, Node node2) { none() } /** - * Holds if the analysis should assume that data may flow from `node1` to `node2` - * in addition to the normal dataflow steps. This step is only applicable in `state1` and - * updates the flow state to `state2`. + * Holds if data may flow from `node1` to `node2` in addition to the normal dataflow steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalFlowStep(Node node1, FlowState state1, Node node2, FlowState state2) { none() diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttracking1/TaintTrackingImpl.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttracking1/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttracking1/TaintTrackingImpl.qll +++ b/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttracking1/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2, diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttrackingforlibraries/TaintTrackingImpl.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttrackingforlibraries/TaintTrackingImpl.qll index 782274d6b8d..8ef73014237 100644 --- a/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttrackingforlibraries/TaintTrackingImpl.qll +++ b/ruby/ql/lib/codeql/ruby/dataflow/internal/tainttrackingforlibraries/TaintTrackingImpl.qll @@ -154,8 +154,7 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. */ predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) { none() } @@ -165,9 +164,8 @@ abstract class Configuration extends DataFlow::Configuration { } /** - * Holds if the analysis should assume that taint may flow from `node1` to `node2` - * in addition to the normal dataflow and taint steps. This step is only applicable - * in `state1` and updates the flow state to `state2`. + * Holds if taint may propagate from `node1` to `node2` in addition to the normal dataflow and taint steps. + * This step is only applicable in `state1` and updates the flow state to `state2`. */ predicate isAdditionalTaintStep( DataFlow::Node node1, DataFlow::FlowState state1, DataFlow::Node node2,