hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9399 from geoffw0/cleartextbufferwriteperf

Browse Source 
C++: Improve performance of Printf::callsVariadicFormatter.
This commit is contained in:
Geoffrey White
2022-06-13 14:32:55 +01:00
committed by GitHub
parent caf1d45bc6 cd4ff54743
commit 3ae60808c1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/lib/semmle/code/cpp/commons/Printf.qll
View File

@@ -168,7 +168,7 @@ private predicate callsVariadicFormatter(
) { ) {
// calls a variadic formatter with `formatParamIndex`, `outputParamIndex` linked // calls a variadic formatter with `formatParamIndex`, `outputParamIndex` linked
exists(FunctionCall fc, int format, int output | exists(FunctionCall fc, int format, int output |
variadicFormatter(fc.getTarget(), type, format, output) and variadicFormatter(pragma[only_bind_into](fc.getTarget()), type, format, output) and
fc.getEnclosingFunction() = f and fc.getEnclosingFunction() = f and
fc.getArgument(format) = f.getParameter(formatParamIndex).getAnAccess() and fc.getArgument(format) = f.getParameter(formatParamIndex).getAnAccess() and
fc.getArgument(output) = f.getParameter(outputParamIndex).getAnAccess() fc.getArgument(output) = f.getParameter(outputParamIndex).getAnAccess()
@@ -176,7 +176,7 @@ private predicate callsVariadicFormatter(
or or
// calls a variadic formatter with only `formatParamIndex` linked // calls a variadic formatter with only `formatParamIndex` linked
exists(FunctionCall fc, string calledType, int format, int output | exists(FunctionCall fc, string calledType, int format, int output |
variadicFormatter(fc.getTarget(), calledType, format, output) and variadicFormatter(pragma[only_bind_into](fc.getTarget()), calledType, format, output) and
fc.getEnclosingFunction() = f and fc.getEnclosingFunction() = f and
fc.getArgument(format) = f.getParameter(formatParamIndex).getAnAccess() and fc.getArgument(format) = f.getParameter(formatParamIndex).getAnAccess() and
not fc.getArgument(output) = f.getParameter(_).getAnAccess() and not fc.getArgument(output) = f.getParameter(_).getAnAccess() and