hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Ignore delete expressions in js/missing-await

Browse Source
This commit is contained in:
Asger Feldthaus
2020-04-02 11:26:04 +01:00
parent ccce0205b4
commit 3a9d047cf5
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/src/Expressions/MissingAwait.ql
View File

@@ -45,7 +45,8 @@ predicate isBadPromiseContext(Expr expr) {
or
exists(UnaryExpr e |
expr = e.getOperand() and
not e instanceof VoidExpr
not e instanceof VoidExpr and
not e instanceof DeleteExpr
)
or
expr = any(UpdateExpr e).getOperand()

1
javascript/ql/test/query-tests/Expressions/MissingAwait/MissingAwait.expected
View File

@@ -1,4 +1,3 @@
| tsTest.ts:4:12:4:19 | cache[x] | Missing await. This value is always a promise. |
| tst.js:8:9:8:13 | thing | Missing await. The value 'thing' is always a promise. |
| tst.js:10:9:10:13 | thing | Missing await. The value 'thing' is always a promise. |
| tst.js:12:15:12:19 | thing | Missing await. The value 'thing' is always a promise. |