hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
This commit is contained in:
yoff
2020-09-10 15:06:06 +02:00
committed by GitHub
parent 2eb8ea85fb
commit 3a19b1e7fd
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
python/ql/src/experimental/dataflow/internal/DataFlowPrivate.qll
View File

@@ -156,8 +156,7 @@ predicate simpleLocalFlowStep(Node nodeFrom, Node nodeTo) {
}
/**
* If a node `n` has a post-update node `pun(n)`, we want forward flow to go from
* `pun(n)` as well as from `n`.
* Holds if `result` is either `node`, or the post-update node for `node`.
*/
private Node update(Node node) {
exists(PostUpdateNode pun |

4
python/ql/src/semmle/python/essa/SsaCompute.qll
View File

@@ -391,7 +391,9 @@ private module SsaComputeImpl {
* between `b1` and `b2`.
*/
private predicate varBlockReaches(SsaSourceVariable v, BasicBlock b1, BasicBlock b2) {
varOccursInBlock(v, b1) and b2 = b1.getASuccessor()
varOccursInBlock(v, b1) and
b2 = b1.getASuccessor() and
blockPrecedesVar(v, b2)
or
exists(BasicBlock mid |
varBlockReaches(v, b1, mid) and