hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

java: fix ql alerts

Browse Source
This commit is contained in:
yoff
2025-10-17 01:52:23 +02:00
parent 61a3e9630f
commit 3a0a8999d5
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/lib/semmle/code/java/ConflictingAccess.qll
View File

@@ -185,7 +185,7 @@ class ClassAnnotatedAsThreadSafe extends Class {
Monitors::locallyMonitors(e, monitor)
or
// recursive case
exists(MethodCall c, Expr e0, Method m0 | this.has_onelocked_access(f, e0, m0, write, monitor) |
exists(MethodCall c, Method m0 | this.has_onelocked_access(f, _, m0, write, monitor) |
m = c.getEnclosingCallable() and
not m0.isPublic() and
c.getCallee().getSourceDeclaration() = m0 and
@@ -223,8 +223,8 @@ class ClassAnnotatedAsThreadSafe extends Class {
not this.has_unlocked_public_access(f, _, _, _)
or
// recursive case
exists(MethodCall c, Expr e0, Method m0, Monitors::Monitor monitor0 |
this.has_onepluslocked_access(f, e0, m0, write, monitor0) and
exists(MethodCall c, Method m0, Monitors::Monitor monitor0 |
this.has_onepluslocked_access(f, _, m0, write, monitor0) and
m = c.getEnclosingCallable() and
not m0.isPublic() and
c.getCallee().getSourceDeclaration() = m0 and
@@ -258,7 +258,7 @@ class ClassAnnotatedAsThreadSafe extends Class {
not Monitors::locallyMonitors(e, monitor)
or
// recursive case
exists(MethodCall c, Expr e0, Method m0 | this.escapes_monitor(f, e0, m0, write, monitor) |
exists(MethodCall c, Method m0 | this.escapes_monitor(f, _, m0, write, monitor) |
m = c.getEnclosingCallable() and
not m0.isPublic() and
c.getCallee().getSourceDeclaration() = m0 and